public inbox for [email protected]
help / color / mirror / Atom feedFrom: Álvaro Herrera <[email protected]>
To: [email protected]
Subject: pgsql: Avoid name collision with NOT NULL constraints
Date: Sat, 21 Feb 2026 11:25:23 +0000
Message-ID: <[email protected]> (raw)
Avoid name collision with NOT NULL constraints
If a CREATE TABLE statement defined a constraint whose name is identical
to the name generated for a NOT NULL constraint, we'd throw an
(unnecessary) unique key violation error on
pg_constraint_conrelid_contypid_conname_index: this can easily be
avoided by choosing a different name for the NOT NULL constraint.
Fix by passing the constraint names already created by
AddRelationNewConstraints() to AddRelationNotNullConstraints(), so that
the latter can avoid name collisions with them.
Bug: #19393
Author: Laurenz Albe <[email protected]>
Reported-by: Hüseyin Demir <[email protected]>
Backpatch-through: 18
Discussion: https://postgr.es/m/[email protected]
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0eeffd31bf9bb73446387cd7eebbbf43148aa281
Modified Files
--------------
src/backend/catalog/heap.c | 8 +++++---
src/backend/commands/tablecmds.c | 18 ++++++++++++++----
src/include/catalog/heap.h | 3 ++-
src/test/regress/expected/create_table.out | 6 ++++++
src/test/regress/sql/create_table.sql | 7 +++++++
5 files changed, 34 insertions(+), 8 deletions(-)
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgsql: Avoid name collision with NOT NULL constraints
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox