public inbox for [email protected]
help / color / mirror / Atom feedpgsql: Fix additional fallthrough warnings from clang
2+ messages / 1 participants
[nested] [flat]
* pgsql: Fix additional fallthrough warnings from clang
@ 2026-02-23 07:00 Peter Eisentraut <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Peter Eisentraut @ 2026-02-23 07:00 UTC (permalink / raw)
To: [email protected]
Fix additional fallthrough warnings from clang
Clang warns if falling through to a case or default label that is
immediately followed by break, but GCC does
not (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91432). (MSVC also
warns about the equivalent code in C++.)
This is in preparation for enabling fallthrough warnings on Clang.
Reviewed-by: Jelte Fennema-Nio <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/76a8efcd-925a-4eaf-bdd1-d972cd1a32ff%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3a63b76571ba253e2784ba34377cdcbdb8ad6796
Modified Files
--------------
contrib/isn/isn.c | 1 +
contrib/pg_overexplain/pg_overexplain.c | 1 +
src/backend/access/transam/xlogrecovery.c | 1 +
src/backend/replication/logical/decode.c | 3 +--
src/backend/tcop/dest.c | 1 +
src/backend/utils/mb/conversion_procs/euc_tw_and_big5/big5.c | 1 +
src/pl/plpgsql/src/pl_comp.c | 1 +
src/tools/pg_bsd_indent/indent.c | 1 +
8 files changed, 8 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix additional fallthrough warning
@ 2026-02-23 07:00 Peter Eisentraut <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Peter Eisentraut @ 2026-02-23 07:00 UTC (permalink / raw)
To: [email protected]
Fix additional fallthrough warning
Clang warns about this one, but GCC did not. (Apparently a bug in
GCC: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=122796)
Apparently, the previous "fall through" comment was introduced
manually in commit f76892c9ff7e without the compiler actually asking
for it.
This is in preparation for enabling fallthrough warnings on Clang.
Reviewed-by: Jelte Fennema-Nio <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/76a8efcd-925a-4eaf-bdd1-d972cd1a32ff%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3f7a0e1e55eff9d96c6d4ac8aa03895de21e06bc
Modified Files
--------------
src/bin/scripts/reindexdb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-02-23 07:00 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-23 07:00 pgsql: Fix additional fallthrough warnings from clang Peter Eisentraut <[email protected]>
2026-02-23 07:00 pgsql: Fix additional fallthrough warning Peter Eisentraut <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox