public inbox for [email protected]  
help / color / mirror / Atom feed
From: John Naylor <[email protected]>
To: [email protected]
Subject: pgsql: Rename pg_crc32c_sse42_choose.c for general purpose
Date: Mon, 23 Feb 2026 12:35:04 +0000
Message-ID: <[email protected]> (raw)

Rename pg_crc32c_sse42_choose.c for general purpose

Future commits will consolidate the CPU feature detection functionality
now scattered around in various files, and the CRC "*_choose.c"
files seem to be the natural place for it. For now, just rename in
a separate commit to make it easier to follow the git log. Do the
minimum necessary to keep the build systems functional, and build the
new file pg_cpu_x86.c unconditionally using guards to control the
visibility of its contents, following the model of some more recent
files in src/port.

Limit scope to x86 to reduce the number of moving parts, since the
motivation for doing this now is to clear out some technical debt
before adding AVX2 detection. Arm is left for future work.

Reviewed-by: Zsolt Parragi <[email protected]>
Discussion: https://postgr.es/m/CANWCAZbgEUFw7LuYSVeJ=Tj98R5HoOB1Ffeqk3aLvbw5rU5NTw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b9278871f991e0c1419b96b7508fe5206903fb1a

Modified Files
--------------
configure                                           | 4 ++--
configure.ac                                        | 4 ++--
src/port/Makefile                                   | 1 +
src/port/meson.build                                | 3 +--
src/port/{pg_crc32c_sse42_choose.c => pg_cpu_x86.c} | 8 ++++++--
5 files changed, 12 insertions(+), 8 deletions(-)



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Rename pg_crc32c_sse42_choose.c for general purpose
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox