public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: [email protected]
Subject: pgsql: Rename validate_relation_kind()
Date: Mon, 23 Feb 2026 16:43:30 +0000
Message-ID: <[email protected]> (raw)
Rename validate_relation_kind()
There are three static definitions of validate_relation_kind() in the
codebase, one each in table.c, indexam.c and sequence.c, validating that
the given relation is a table, an index or a sequence respectively.
The compiler knows which definition to use where because they are static.
But this could be confusing to a reader. Rename these functions so that
their names reflect the kind of relation they are validating. While at
it, also update the comments in table.c to clarify the definition of
table-like relkinds so that we don't have to maintain the exclusion list
as the set of relkinds undergoes changes.
Author: Ashutosh Bapat <[email protected]>
Reviewed-by: Junwang Zhao <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/6d3fef19-a420-4e11-8235-8ea534bf2080%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/797872f6b9c929a78677999c323ddc1ccb4e30d0
Modified Files
--------------
src/backend/access/index/indexam.c | 10 +++++-----
src/backend/access/sequence/sequence.c | 8 ++++----
src/backend/access/table/table.c | 18 +++++++++---------
3 files changed, 18 insertions(+), 18 deletions(-)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgsql: Rename validate_relation_kind()
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox