public inbox for [email protected]help / color / mirror / Atom feed
pgsql: Stabilize output of new isolation test insert-conflict-do-update 6+ messages / 1 participants [nested] [flat]
* pgsql: Stabilize output of new isolation test insert-conflict-do-update @ 2026-02-25 15:51 Tom Lane <[email protected]> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-02-25 15:51 UTC (permalink / raw) To: [email protected] Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3fd53bab for instance. Adding an ORDER BY is cheap insurance and doesn't break any goal of the test. Author: Pavel Borisov <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/CALT9ZEHcE6tpvumScYPO6pGk_ASjTjWojLkodHnk33dvRPHXVw@mail.gmail.com Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4c1a27e53a508f74883cda52a6c8612121d7fd6b Modified Files -------------- src/test/isolation/expected/insert-conflict-do-update-4.out | 8 ++++---- src/test/isolation/specs/insert-conflict-do-update-4.spec | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Stabilize output of new isolation test insert-conflict-do-update @ 2026-02-25 15:51 Tom Lane <[email protected]> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-02-25 15:51 UTC (permalink / raw) To: [email protected] Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3fd53bab for instance. Adding an ORDER BY is cheap insurance and doesn't break any goal of the test. Author: Pavel Borisov <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/CALT9ZEHcE6tpvumScYPO6pGk_ASjTjWojLkodHnk33dvRPHXVw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0a2600e4cd525382212581267877ca6e5bbdf335 Modified Files -------------- src/test/isolation/expected/insert-conflict-do-update-4.out | 8 ++++---- src/test/isolation/specs/insert-conflict-do-update-4.spec | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Stabilize output of new isolation test insert-conflict-do-update @ 2026-02-25 15:51 Tom Lane <[email protected]> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-02-25 15:51 UTC (permalink / raw) To: [email protected] Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3fd53bab for instance. Adding an ORDER BY is cheap insurance and doesn't break any goal of the test. Author: Pavel Borisov <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/CALT9ZEHcE6tpvumScYPO6pGk_ASjTjWojLkodHnk33dvRPHXVw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5d311d6a845ae4423a716ae422f1462128c33125 Modified Files -------------- src/test/isolation/expected/insert-conflict-do-update-4.out | 8 ++++---- src/test/isolation/specs/insert-conflict-do-update-4.spec | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Stabilize output of new isolation test insert-conflict-do-update @ 2026-02-25 15:51 Tom Lane <[email protected]> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-02-25 15:51 UTC (permalink / raw) To: [email protected] Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3fd53bab for instance. Adding an ORDER BY is cheap insurance and doesn't break any goal of the test. Author: Pavel Borisov <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/CALT9ZEHcE6tpvumScYPO6pGk_ASjTjWojLkodHnk33dvRPHXVw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/aeaf2fc0ddbfb1e4a706555e33d9b4165d110a1c Modified Files -------------- src/test/isolation/expected/insert-conflict-do-update-4.out | 8 ++++---- src/test/isolation/specs/insert-conflict-do-update-4.spec | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Stabilize output of new isolation test insert-conflict-do-update @ 2026-02-25 15:51 Tom Lane <[email protected]> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-02-25 15:51 UTC (permalink / raw) To: [email protected] Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3fd53bab for instance. Adding an ORDER BY is cheap insurance and doesn't break any goal of the test. Author: Pavel Borisov <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/CALT9ZEHcE6tpvumScYPO6pGk_ASjTjWojLkodHnk33dvRPHXVw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/25b67fa7daa2d8d5452a1c9415ed16914ac6ba15 Modified Files -------------- src/test/isolation/expected/insert-conflict-do-update-4.out | 8 ++++---- src/test/isolation/specs/insert-conflict-do-update-4.spec | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Stabilize output of new isolation test insert-conflict-do-update @ 2026-02-25 15:51 Tom Lane <[email protected]> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-02-25 15:51 UTC (permalink / raw) To: [email protected] Stabilize output of new isolation test insert-conflict-do-update-4. The test added by commit 4b760a181 assumed that a table's physical row order would be predictable after an UPDATE. But a non-heap table AM might produce some other order. Even with heap AM, the assumption seems risky; compare a3fd53bab for instance. Adding an ORDER BY is cheap insurance and doesn't break any goal of the test. Author: Pavel Borisov <[email protected]> Reviewed-by: Tom Lane <[email protected]> Discussion: https://postgr.es/m/CALT9ZEHcE6tpvumScYPO6pGk_ASjTjWojLkodHnk33dvRPHXVw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b57d35dde7dde5e94ce534a6f2a0a24cb5ccb2c1 Modified Files -------------- src/test/isolation/expected/insert-conflict-do-update-4.out | 8 ++++---- src/test/isolation/specs/insert-conflict-do-update-4.spec | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-02-25 15:51 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-02-25 15:51 pgsql: Stabilize output of new isolation test insert-conflict-do-update Tom Lane <[email protected]> 2026-02-25 15:51 pgsql: Stabilize output of new isolation test insert-conflict-do-update Tom Lane <[email protected]> 2026-02-25 15:51 pgsql: Stabilize output of new isolation test insert-conflict-do-update Tom Lane <[email protected]> 2026-02-25 15:51 pgsql: Stabilize output of new isolation test insert-conflict-do-update Tom Lane <[email protected]> 2026-02-25 15:51 pgsql: Stabilize output of new isolation test insert-conflict-do-update Tom Lane <[email protected]> 2026-02-25 15:51 pgsql: Stabilize output of new isolation test insert-conflict-do-update Tom Lane <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox