public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: [email protected]
Subject: pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.
Date: Wed, 25 Feb 2026 16:57:42 +0000
Message-ID: <[email protected]> (raw)
Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.
Although clang claims to be compatible with gcc's printf format
archetypes, this appears to be a falsehood: it likes __syslog__
(which gcc does not, on most platforms) and doesn't accept
gnu_printf. This means that if you try to use gcc with clang++
or clang with g++, you get compiler warnings when compiling
printf-like calls in our C++ code. This has been true for quite
awhile, but it's gotten more annoying with the recent appearance
of several buildfarm members that are configured like this.
To fix, run separate probes for the format archetype to use with the
C and C++ compilers, and conditionally define PG_PRINTF_ATTRIBUTE
depending on __cplusplus.
(We could alternatively insist that you not mix-and-match C and
C++ compilers; but if the case works otherwise, this is a poor
reason to insist on that.)
This commit back-patches 0909380e4 into supported branches.
Discussion: https://postgr.es/m/[email protected]
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 14-18
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/7e788a585a6c29b12fcb53a313ac5c4d080c36e8
Modified Files
--------------
config/c-compiler.m4 | 46 +++++++++++++++++++---
configure | 96 ++++++++++++++++++++++++++++++++++++++++++++--
configure.ac | 1 +
src/include/c.h | 10 +++++
src/include/pg_config.h.in | 11 ++++--
5 files changed, 153 insertions(+), 11 deletions(-)
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgsql: Allow PG_PRINTF_ATTRIBUTE to be different in C and C++ code.
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox