public inbox for [email protected]  
help / color / mirror / Atom feed
From: John Naylor <[email protected]>
To: [email protected]
Subject: pgsql: Centralize detection of x86 CPU features
Date: Fri, 27 Feb 2026 13:32:08 +0000
Message-ID: <[email protected]> (raw)

Centralize detection of x86 CPU features

We now maintain an array of booleans that indicate which features were
detected at runtime. When code wants to check for a given feature,
the array is automatically checked if it has been initialized and if
not, a single function checks all features at once.

Move all x86 feature detection to pg_cpu_x86.c, and move the CRC
function choosing logic to the file where the hardware-specific
functions are defined, consistent with more recent hardware-specific
files in src/port.

Reviewed-by: Zsolt Parragi <[email protected]>
Discussion: https://postgr.es/m/CANWCAZbgEUFw7LuYSVeJ=Tj98R5HoOB1Ffeqk3aLvbw5rU5NTw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/16743db061e431d40522547c6436af6616026caa

Modified Files
--------------
src/include/port/pg_cpu.h        | 50 ++++++++++++++++++++++
src/port/pg_cpu_x86.c            | 65 +++++++++++-----------------
src/port/pg_crc32c_sse42.c       | 32 ++++++++++++++
src/port/pg_popcount_x86.c       | 91 ++--------------------------------------
src/tools/pgindent/typedefs.list |  1 +
5 files changed, 112 insertions(+), 127 deletions(-)



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Centralize detection of x86 CPU features
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox