public inbox for [email protected]help / color / mirror / Atom feed
pgsql: basic_archive: Allow archive directory to be missing at startup. 5+ messages / 1 participants [nested] [flat]
* pgsql: basic_archive: Allow archive directory to be missing at startup. @ 2026-03-02 19:15 Nathan Bossart <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Nathan Bossart @ 2026-03-02 19:15 UTC (permalink / raw) To: [email protected] basic_archive: Allow archive directory to be missing at startup. Presently, the GUC check hook for basic_archive.archive_directory checks that the specified directory exists. Consequently, if the directory does not exist at server startup, archiving will be stuck indefinitely, even if it appears later. To fix, remove this check from the hook so that archiving will resume automatically once the directory is present. basic_archive must already be prepared to deal with the directory disappearing at any time, so no additional special handling is required. Reported-by: Олег Самойлов <[email protected]> Reviewed-by: Tom Lane <[email protected]> Reviewed-by: Fujii Masao <[email protected]> Reviewed-by: Sergei Kornilov <[email protected]> Discussion: https://postgr.es/m/73271769675212%40mail.yandex.ru Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/cc774c543b23e91175642a65559aae456f17d89e Modified Files -------------- contrib/basic_archive/basic_archive.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: basic_archive: Allow archive directory to be missing at startup. @ 2026-03-02 19:15 Nathan Bossart <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Nathan Bossart @ 2026-03-02 19:15 UTC (permalink / raw) To: [email protected] basic_archive: Allow archive directory to be missing at startup. Presently, the GUC check hook for basic_archive.archive_directory checks that the specified directory exists. Consequently, if the directory does not exist at server startup, archiving will be stuck indefinitely, even if it appears later. To fix, remove this check from the hook so that archiving will resume automatically once the directory is present. basic_archive must already be prepared to deal with the directory disappearing at any time, so no additional special handling is required. Reported-by: Олег Самойлов <[email protected]> Reviewed-by: Tom Lane <[email protected]> Reviewed-by: Fujii Masao <[email protected]> Reviewed-by: Sergei Kornilov <[email protected]> Discussion: https://postgr.es/m/73271769675212%40mail.yandex.ru Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f510577de4f5a0b33453941a08cdb2302dc55f02 Modified Files -------------- contrib/basic_archive/basic_archive.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: basic_archive: Allow archive directory to be missing at startup. @ 2026-03-02 19:15 Nathan Bossart <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Nathan Bossart @ 2026-03-02 19:15 UTC (permalink / raw) To: [email protected] basic_archive: Allow archive directory to be missing at startup. Presently, the GUC check hook for basic_archive.archive_directory checks that the specified directory exists. Consequently, if the directory does not exist at server startup, archiving will be stuck indefinitely, even if it appears later. To fix, remove this check from the hook so that archiving will resume automatically once the directory is present. basic_archive must already be prepared to deal with the directory disappearing at any time, so no additional special handling is required. Reported-by: Олег Самойлов <[email protected]> Reviewed-by: Tom Lane <[email protected]> Reviewed-by: Fujii Masao <[email protected]> Reviewed-by: Sergei Kornilov <[email protected]> Discussion: https://postgr.es/m/73271769675212%40mail.yandex.ru Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/28c2b789652a8df0999d5dbfefa2482dafdcaaa1 Modified Files -------------- contrib/basic_archive/basic_archive.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: basic_archive: Allow archive directory to be missing at startup. @ 2026-03-02 19:15 Nathan Bossart <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Nathan Bossart @ 2026-03-02 19:15 UTC (permalink / raw) To: [email protected] basic_archive: Allow archive directory to be missing at startup. Presently, the GUC check hook for basic_archive.archive_directory checks that the specified directory exists. Consequently, if the directory does not exist at server startup, archiving will be stuck indefinitely, even if it appears later. To fix, remove this check from the hook so that archiving will resume automatically once the directory is present. basic_archive must already be prepared to deal with the directory disappearing at any time, so no additional special handling is required. Reported-by: Олег Самойлов <[email protected]> Reviewed-by: Tom Lane <[email protected]> Reviewed-by: Fujii Masao <[email protected]> Reviewed-by: Sergei Kornilov <[email protected]> Discussion: https://postgr.es/m/73271769675212%40mail.yandex.ru Backpatch-through: 15 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bde9ad31515a92ce23c9b9e113f08a71ca0f7dd1 Modified Files -------------- contrib/basic_archive/basic_archive.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: basic_archive: Allow archive directory to be missing at startup. @ 2026-03-02 19:15 Nathan Bossart <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Nathan Bossart @ 2026-03-02 19:15 UTC (permalink / raw) To: [email protected] basic_archive: Allow archive directory to be missing at startup. Presently, the GUC check hook for basic_archive.archive_directory checks that the specified directory exists. Consequently, if the directory does not exist at server startup, archiving will be stuck indefinitely, even if it appears later. To fix, remove this check from the hook so that archiving will resume automatically once the directory is present. basic_archive must already be prepared to deal with the directory disappearing at any time, so no additional special handling is required. Reported-by: Олег Самойлов <[email protected]> Reviewed-by: Tom Lane <[email protected]> Reviewed-by: Fujii Masao <[email protected]> Reviewed-by: Sergei Kornilov <[email protected]> Discussion: https://postgr.es/m/73271769675212%40mail.yandex.ru Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8fc45ac5d91a0834f6bca1405309749e6ec687dd Modified Files -------------- contrib/basic_archive/basic_archive.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-03-02 19:15 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-03-02 19:15 pgsql: basic_archive: Allow archive directory to be missing at startup. Nathan Bossart <[email protected]> 2026-03-02 19:15 pgsql: basic_archive: Allow archive directory to be missing at startup. Nathan Bossart <[email protected]> 2026-03-02 19:15 pgsql: basic_archive: Allow archive directory to be missing at startup. Nathan Bossart <[email protected]> 2026-03-02 19:15 pgsql: basic_archive: Allow archive directory to be missing at startup. Nathan Bossart <[email protected]> 2026-03-02 19:15 pgsql: basic_archive: Allow archive directory to be missing at startup. Nathan Bossart <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox