pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: doc: Clarify that empty COMMENT string removes the comment. 6+ messages / 1 participants [nested] [flat]
* pgsql: doc: Clarify that empty COMMENT string removes the comment. @ 2026-03-03 05:49 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2026-03-03 05:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org doc: Clarify that empty COMMENT string removes the comment. Clarify the documentation of COMMENT ON to state that specifying an empty string is treated as NULL, meaning that the comment is removed. This makes the behavior explicit and avoids possible confusion about how empty strings are handled. Also adds regress test cases that use empty string to remove a comment. Backpatch to all supported versions. Author: Chao Li <lic@highgo.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: David G. Johnston <david.g.johnston@gmail.com> Reviewed-by: Shengbin Zhao <zshengbin91@gmail.com> Reviewed-by: Jim Jones <jim.jones@uni-muenster.de> Reviewed-by: zhangqiang <zhang_qiang81@163.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/26476097-B1C1-4BA8-AA92-0AD0B8EC7190@gmail.com Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/bae42a54e3dfb935e55f54c0ff350bdfd4503815 Modified Files -------------- doc/src/sgml/ref/comment.sgml | 18 +++++++++++------- src/test/regress/expected/create_index.out | 14 ++++++++++++++ src/test/regress/expected/create_role.out | 27 +++++++++++++++++++++++++++ src/test/regress/sql/create_index.sql | 4 ++++ src/test/regress/sql/create_role.sql | 7 +++++++ 5 files changed, 63 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: doc: Clarify that empty COMMENT string removes the comment. @ 2026-03-03 05:49 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2026-03-03 05:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org doc: Clarify that empty COMMENT string removes the comment. Clarify the documentation of COMMENT ON to state that specifying an empty string is treated as NULL, meaning that the comment is removed. This makes the behavior explicit and avoids possible confusion about how empty strings are handled. Also adds regress test cases that use empty string to remove a comment. Backpatch to all supported versions. Author: Chao Li <lic@highgo.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: David G. Johnston <david.g.johnston@gmail.com> Reviewed-by: Shengbin Zhao <zshengbin91@gmail.com> Reviewed-by: Jim Jones <jim.jones@uni-muenster.de> Reviewed-by: zhangqiang <zhang_qiang81@163.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/26476097-B1C1-4BA8-AA92-0AD0B8EC7190@gmail.com Backpatch-through: 14 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/47ad672a76d30110254561960f1fe33e453cf8fe Modified Files -------------- doc/src/sgml/ref/comment.sgml | 18 +++++++++++------- src/test/regress/expected/create_index.out | 14 ++++++++++++++ src/test/regress/expected/create_role.out | 27 +++++++++++++++++++++++++++ src/test/regress/sql/create_index.sql | 4 ++++ src/test/regress/sql/create_role.sql | 7 +++++++ 5 files changed, 63 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: doc: Clarify that empty COMMENT string removes the comment. @ 2026-03-03 05:49 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2026-03-03 05:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org doc: Clarify that empty COMMENT string removes the comment. Clarify the documentation of COMMENT ON to state that specifying an empty string is treated as NULL, meaning that the comment is removed. This makes the behavior explicit and avoids possible confusion about how empty strings are handled. Also adds regress test cases that use empty string to remove a comment. Backpatch to all supported versions. Author: Chao Li <lic@highgo.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: David G. Johnston <david.g.johnston@gmail.com> Reviewed-by: Shengbin Zhao <zshengbin91@gmail.com> Reviewed-by: Jim Jones <jim.jones@uni-muenster.de> Reviewed-by: zhangqiang <zhang_qiang81@163.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/26476097-B1C1-4BA8-AA92-0AD0B8EC7190@gmail.com Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ec80fab7a1fdaeb15041f312447f32dd0420d46f Modified Files -------------- doc/src/sgml/ref/comment.sgml | 18 +++++++++++------- src/test/regress/expected/create_index.out | 14 ++++++++++++++ src/test/regress/expected/create_role.out | 27 +++++++++++++++++++++++++++ src/test/regress/sql/create_index.sql | 4 ++++ src/test/regress/sql/create_role.sql | 7 +++++++ 5 files changed, 63 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: doc: Clarify that empty COMMENT string removes the comment. @ 2026-03-03 05:49 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2026-03-03 05:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org doc: Clarify that empty COMMENT string removes the comment. Clarify the documentation of COMMENT ON to state that specifying an empty string is treated as NULL, meaning that the comment is removed. This makes the behavior explicit and avoids possible confusion about how empty strings are handled. Also adds regress test cases that use empty string to remove a comment. Backpatch to all supported versions. Author: Chao Li <lic@highgo.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: David G. Johnston <david.g.johnston@gmail.com> Reviewed-by: Shengbin Zhao <zshengbin91@gmail.com> Reviewed-by: Jim Jones <jim.jones@uni-muenster.de> Reviewed-by: zhangqiang <zhang_qiang81@163.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/26476097-B1C1-4BA8-AA92-0AD0B8EC7190@gmail.com Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/228addbbf2c13f8cc8f80bb6f0aa5bd7204e65e5 Modified Files -------------- doc/src/sgml/ref/comment.sgml | 18 +++++++++++------- src/test/regress/expected/create_index.out | 14 ++++++++++++++ src/test/regress/expected/create_role.out | 27 +++++++++++++++++++++++++++ src/test/regress/sql/create_index.sql | 4 ++++ src/test/regress/sql/create_role.sql | 7 +++++++ 5 files changed, 63 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: doc: Clarify that empty COMMENT string removes the comment. @ 2026-03-03 05:50 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2026-03-03 05:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org doc: Clarify that empty COMMENT string removes the comment. Clarify the documentation of COMMENT ON to state that specifying an empty string is treated as NULL, meaning that the comment is removed. This makes the behavior explicit and avoids possible confusion about how empty strings are handled. Also adds regress test cases that use empty string to remove a comment. Backpatch to all supported versions. Author: Chao Li <lic@highgo.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: David G. Johnston <david.g.johnston@gmail.com> Reviewed-by: Shengbin Zhao <zshengbin91@gmail.com> Reviewed-by: Jim Jones <jim.jones@uni-muenster.de> Reviewed-by: zhangqiang <zhang_qiang81@163.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/26476097-B1C1-4BA8-AA92-0AD0B8EC7190@gmail.com Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4574dd44da3c0a922ebd7117ee5229dbe3f2c84f Modified Files -------------- doc/src/sgml/ref/comment.sgml | 18 +++++++++++------- src/test/regress/expected/create_index.out | 14 ++++++++++++++ src/test/regress/expected/create_role.out | 28 ++++++++++++++++++++++++++++ src/test/regress/sql/create_index.sql | 4 ++++ src/test/regress/sql/create_role.sql | 8 ++++++++ 5 files changed, 65 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: doc: Clarify that empty COMMENT string removes the comment. @ 2026-03-03 05:50 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Fujii Masao @ 2026-03-03 05:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org doc: Clarify that empty COMMENT string removes the comment. Clarify the documentation of COMMENT ON to state that specifying an empty string is treated as NULL, meaning that the comment is removed. This makes the behavior explicit and avoids possible confusion about how empty strings are handled. Also adds regress test cases that use empty string to remove a comment. Backpatch to all supported versions. Author: Chao Li <lic@highgo.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: David G. Johnston <david.g.johnston@gmail.com> Reviewed-by: Shengbin Zhao <zshengbin91@gmail.com> Reviewed-by: Jim Jones <jim.jones@uni-muenster.de> Reviewed-by: zhangqiang <zhang_qiang81@163.com> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/26476097-B1C1-4BA8-AA92-0AD0B8EC7190@gmail.com Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7ab6ac1d7f50eb4a36280cbbee3be68bc19d28ca Modified Files -------------- doc/src/sgml/ref/comment.sgml | 18 +++++++++++------- src/test/regress/expected/create_index.out | 14 ++++++++++++++ src/test/regress/sql/create_index.sql | 4 ++++ 3 files changed, 29 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-03-03 05:50 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-03-03 05:49 pgsql: doc: Clarify that empty COMMENT string removes the comment. Fujii Masao <fujii@postgresql.org> 2026-03-03 05:49 pgsql: doc: Clarify that empty COMMENT string removes the comment. Fujii Masao <fujii@postgresql.org> 2026-03-03 05:49 pgsql: doc: Clarify that empty COMMENT string removes the comment. Fujii Masao <fujii@postgresql.org> 2026-03-03 05:49 pgsql: doc: Clarify that empty COMMENT string removes the comment. Fujii Masao <fujii@postgresql.org> 2026-03-03 05:50 pgsql: doc: Clarify that empty COMMENT string removes the comment. Fujii Masao <fujii@postgresql.org> 2026-03-03 05:50 pgsql: doc: Clarify that empty COMMENT string removes the comment. Fujii Masao <fujii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox