pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Don't leave behind files in src dir in 007_multixact_conversion.
3+ messages / 3 participants
[nested] [flat]

* pgsql: Don't leave behind files in src dir in 007_multixact_conversion.
@ 2026-03-17 09:52  Heikki Linnakangas <heikki.linnakangas@iki.fi>
  0 siblings, 1 reply; 3+ messages in thread

From: Heikki Linnakangas @ 2026-03-17 09:52 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Don't leave behind files in src dir in 007_multixact_conversion.pl

pg_upgrade test 007_multixact_conversion.pl was leaving files like
delete_old_cluster.sh in the source directory for VPATH and meson
builds. To fix, change the tmp_check directory before running the
test, like in the other pg_upgrade tests.

Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
https://www.postgresql.org/message-id/TYRPR01MB121563A4DA8B2FE9A2ECB79F5F541A@TYRPR01MB12156.jpnprd0...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2c1a7d421f92c14c8fedbd77200607b3df554add

Modified Files
--------------
src/bin/pg_upgrade/t/007_multixact_conversion.pl | 5 +++++
1 file changed, 5 insertions(+)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Don't leave behind files in src dir in 007_multixact_conversion.
@ 2026-03-18 23:19  Robert Haas <robertmhaas@gmail.com>
  parent: Heikki Linnakangas <heikki.linnakangas@iki.fi>
  0 siblings, 1 reply; 3+ messages in thread

From: Robert Haas @ 2026-03-18 23:19 UTC (permalink / raw)
  To: Heikki Linnakangas <heikki.linnakangas@iki.fi>; Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

On Tue, Mar 17, 2026 at 5:52 AM Heikki Linnakangas
<heikki.linnakangas@iki.fi> wrote:
> Don't leave behind files in src dir in 007_multixact_conversion.pl
>
> pg_upgrade test 007_multixact_conversion.pl was leaving files like
> delete_old_cluster.sh in the source directory for VPATH and meson
> builds. To fix, change the tmp_check directory before running the
> test, like in the other pg_upgrade tests.
>
> Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
> https://www.postgresql.org/message-id/TYRPR01MB121563A4DA8B2FE9A2ECB79F5F541A@TYRPR01MB12156.jpnprd0...

Thank you both! I am VERY happy that someone finally tracked this
down. This has been bugging me for a while, but I haven't had time to
figure out why it was happening.

-- 
Robert Haas
EDB: http://www.enterprisedb.com





^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Don't leave behind files in src dir in 007_multixact_conversion.
@ 2026-03-19 17:56  Andrew Dunstan <andrew@dunslane.net>
  parent: Robert Haas <robertmhaas@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Andrew Dunstan @ 2026-03-19 17:56 UTC (permalink / raw)
  To: Robert Haas <robertmhaas@gmail.com>; Heikki Linnakangas <heikki.linnakangas@iki.fi>; Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>


On 2026-03-18 We 7:19 PM, Robert Haas wrote:
> On Tue, Mar 17, 2026 at 5:52 AM Heikki Linnakangas
> <heikki.linnakangas@iki.fi> wrote:
>> Don't leave behind files in src dir in 007_multixact_conversion.pl
>>
>> pg_upgrade test 007_multixact_conversion.pl was leaving files like
>> delete_old_cluster.sh in the source directory for VPATH and meson
>> builds. To fix, change the tmp_check directory before running the
>> test, like in the other pg_upgrade tests.
>>
>> Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
>> https://www.postgresql.org/message-id/TYRPR01MB121563A4DA8B2FE9A2ECB79F5F541A@TYRPR01MB12156.jpnprd0...
> Thank you both! I am VERY happy that someone finally tracked this
> down. This has been bugging me for a while, but I haven't had time to
> figure out why it was happening.


+1


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2026-03-19 17:56 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-03-17 09:52 pgsql: Don't leave behind files in src dir in 007_multixact_conversion. Heikki Linnakangas <heikki.linnakangas@iki.fi>
2026-03-18 23:19 ` Robert Haas <robertmhaas@gmail.com>
2026-03-19 17:56   ` Andrew Dunstan <andrew@dunslane.net>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox