pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix finalization of decompressor astreamers. 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix finalization of decompressor astreamers. @ 2026-03-22 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2026-03-22 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix finalization of decompressor astreamers. Send the correct amount of data to the next astreamer, not the whole allocated buffer size. This bug escaped detection because in present uses the next astreamer is always a tar-file parser which is insensitive to trailing garbage. But that may not be true in future uses. Author: Andrew Dunstan <andrew@dunslane.net> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/2178517.1774064942@sss.pgh.pa.us Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/80785a527b9cf74b16cb5bb65355f94157124bf7 Modified Files -------------- src/bin/pg_basebackup/bbstreamer_gzip.c | 9 +++++---- src/bin/pg_basebackup/bbstreamer_lz4.c | 9 +++++---- src/bin/pg_basebackup/bbstreamer_zstd.c | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix finalization of decompressor astreamers. @ 2026-03-22 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2026-03-22 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix finalization of decompressor astreamers. Send the correct amount of data to the next astreamer, not the whole allocated buffer size. This bug escaped detection because in present uses the next astreamer is always a tar-file parser which is insensitive to trailing garbage. But that may not be true in future uses. Author: Andrew Dunstan <andrew@dunslane.net> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/2178517.1774064942@sss.pgh.pa.us Backpatch-through: 15 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5f9642614275a56c93774ce536feaa4c27ee2525 Modified Files -------------- src/fe_utils/astreamer_gzip.c | 9 +++++---- src/fe_utils/astreamer_lz4.c | 9 +++++---- src/fe_utils/astreamer_zstd.c | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix finalization of decompressor astreamers. @ 2026-03-22 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2026-03-22 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix finalization of decompressor astreamers. Send the correct amount of data to the next astreamer, not the whole allocated buffer size. This bug escaped detection because in present uses the next astreamer is always a tar-file parser which is insensitive to trailing garbage. But that may not be true in future uses. Author: Andrew Dunstan <andrew@dunslane.net> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/2178517.1774064942@sss.pgh.pa.us Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6ccfc44922123d497501a491b8becfca7b0096bb Modified Files -------------- src/bin/pg_basebackup/bbstreamer_gzip.c | 9 +++++---- src/bin/pg_basebackup/bbstreamer_lz4.c | 9 +++++---- src/bin/pg_basebackup/bbstreamer_zstd.c | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix finalization of decompressor astreamers. @ 2026-03-22 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2026-03-22 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix finalization of decompressor astreamers. Send the correct amount of data to the next astreamer, not the whole allocated buffer size. This bug escaped detection because in present uses the next astreamer is always a tar-file parser which is insensitive to trailing garbage. But that may not be true in future uses. Author: Andrew Dunstan <andrew@dunslane.net> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/2178517.1774064942@sss.pgh.pa.us Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5540f9c430f65631887d31fa26dfdfa576c1c17e Modified Files -------------- src/bin/pg_basebackup/bbstreamer_gzip.c | 9 +++++---- src/bin/pg_basebackup/bbstreamer_lz4.c | 9 +++++---- src/bin/pg_basebackup/bbstreamer_zstd.c | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix finalization of decompressor astreamers. @ 2026-03-22 22:07 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2026-03-22 22:07 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix finalization of decompressor astreamers. Send the correct amount of data to the next astreamer, not the whole allocated buffer size. This bug escaped detection because in present uses the next astreamer is always a tar-file parser which is insensitive to trailing garbage. But that may not be true in future uses. Author: Andrew Dunstan <andrew@dunslane.net> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/2178517.1774064942@sss.pgh.pa.us Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9aa1fcc547021c341606efbc7c343ff96a8bd964 Modified Files -------------- src/fe_utils/astreamer_gzip.c | 9 +++++---- src/fe_utils/astreamer_lz4.c | 9 +++++---- src/fe_utils/astreamer_zstd.c | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-03-22 22:07 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-03-22 22:07 pgsql: Fix finalization of decompressor astreamers. Tom Lane <tgl@sss.pgh.pa.us> 2026-03-22 22:07 pgsql: Fix finalization of decompressor astreamers. Tom Lane <tgl@sss.pgh.pa.us> 2026-03-22 22:07 pgsql: Fix finalization of decompressor astreamers. Tom Lane <tgl@sss.pgh.pa.us> 2026-03-22 22:07 pgsql: Fix finalization of decompressor astreamers. Tom Lane <tgl@sss.pgh.pa.us> 2026-03-22 22:07 pgsql: Fix finalization of decompressor astreamers. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox