pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Improve commentary about ChangeVarNodesWalkExpression(). 2+ messages / 1 participants [nested] [flat]
* pgsql: Improve commentary about ChangeVarNodesWalkExpression(). @ 2026-03-23 15:14 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2026-03-23 15:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve commentary about ChangeVarNodesWalkExpression(). IMO the proximate cause of the bug fixed in commit 07b7a964d was sloppy thinking about what ChangeVarNodesWalkExpression() is to be used for. Flesh out its header comment to try to improve that situation. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/1607553.1774017006@sss.pgh.pa.us Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/360dd6f7b4c522d9a48d4621feb6da0a91bd7594 Modified Files -------------- src/backend/rewrite/rewriteManip.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Improve commentary about ChangeVarNodesWalkExpression(). @ 2026-03-23 15:14 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2026-03-23 15:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve commentary about ChangeVarNodesWalkExpression(). IMO the proximate cause of the bug fixed in commit 07b7a964d was sloppy thinking about what ChangeVarNodesWalkExpression() is to be used for. Flesh out its header comment to try to improve that situation. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/1607553.1774017006@sss.pgh.pa.us Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a0e0b3cc685aa58d9ff63ed64e45ac1cba297e40 Modified Files -------------- src/backend/rewrite/rewriteManip.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-03-23 15:14 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-03-23 15:14 pgsql: Improve commentary about ChangeVarNodesWalkExpression(). Tom Lane <tgl@sss.pgh.pa.us> 2026-03-23 15:14 pgsql: Improve commentary about ChangeVarNodesWalkExpression(). Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox