pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Further improve commentary about ChangeVarNodesWalkExpression()
2+ messages / 1 participants
[nested] [flat]

* pgsql: Further improve commentary about ChangeVarNodesWalkExpression()
@ 2026-03-24 07:54  Alexander Korotkov <akorotkov@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Alexander Korotkov @ 2026-03-24 07:54 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Further improve commentary about ChangeVarNodesWalkExpression()

The updated comment explains why we use ChangeVarNodes_walker() instead of
expression_tree_walker(), and provides a bit more detail about the differences
in processing top-level Query and subqueries.

Author: Alexander Korotkov <aekorotkov@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAPpHfdvbjq342WTQ705Wmqhe8794pcp7wospz%2BWUJ2qB7vuOqA%40mail.gmail.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6888658516a20a2605087f557d96f3d0d0937608

Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Further improve commentary about ChangeVarNodesWalkExpression()
@ 2026-03-24 07:54  Alexander Korotkov <akorotkov@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Alexander Korotkov @ 2026-03-24 07:54 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Further improve commentary about ChangeVarNodesWalkExpression()

The updated comment explains why we use ChangeVarNodes_walker() instead of
expression_tree_walker(), and provides a bit more detail about the differences
in processing top-level Query and subqueries.

Author: Alexander Korotkov <aekorotkov@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAPpHfdvbjq342WTQ705Wmqhe8794pcp7wospz%2BWUJ2qB7vuOqA%40mail.gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8c73ab9da9f191e07d5e1c11b59e2dcbde8cafb8

Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2026-03-24 07:54 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-03-24 07:54 pgsql: Further improve commentary about ChangeVarNodesWalkExpression() Alexander Korotkov <akorotkov@postgresql.org>
2026-03-24 07:54 pgsql: Further improve commentary about ChangeVarNodesWalkExpression() Alexander Korotkov <akorotkov@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox