pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix copy-paste error in test_ginpostinglist 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix copy-paste error in test_ginpostinglist @ 2026-03-24 10:25 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: John Naylor @ 2026-03-24 10:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix copy-paste error in test_ginpostinglist The check for a mismatch on the second decoded item pointer was an exact copy of the first item pointer check, comparing orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1] with decoded_itemptrs[1]. The error message also reported (0, 1) as the expected value instead of (blk, off). As a result, any decoding error in the second item pointer (where the varbyte delta encoding is exercised) would go undetected. This has been wrong since commit bde7493d1, so backpatch to all supported versions. Author: Jianghua Yang <yjhjstz@gmail.com> Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/791ff1df1ee040cf171100b173f88ffd9ea8a446 Modified Files -------------- src/test/modules/test_ginpostinglist/test_ginpostinglist.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix copy-paste error in test_ginpostinglist @ 2026-03-24 10:25 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: John Naylor @ 2026-03-24 10:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix copy-paste error in test_ginpostinglist The check for a mismatch on the second decoded item pointer was an exact copy of the first item pointer check, comparing orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1] with decoded_itemptrs[1]. The error message also reported (0, 1) as the expected value instead of (blk, off). As a result, any decoding error in the second item pointer (where the varbyte delta encoding is exercised) would go undetected. This has been wrong since commit bde7493d1, so backpatch to all supported versions. Author: Jianghua Yang <yjhjstz@gmail.com> Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com Backpatch-through: 14 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/51b7316a7c2b1a87c181842b35e4dcdc31d630f1 Modified Files -------------- src/test/modules/test_ginpostinglist/test_ginpostinglist.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix copy-paste error in test_ginpostinglist @ 2026-03-24 10:25 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: John Naylor @ 2026-03-24 10:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix copy-paste error in test_ginpostinglist The check for a mismatch on the second decoded item pointer was an exact copy of the first item pointer check, comparing orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1] with decoded_itemptrs[1]. The error message also reported (0, 1) as the expected value instead of (blk, off). As a result, any decoding error in the second item pointer (where the varbyte delta encoding is exercised) would go undetected. This has been wrong since commit bde7493d1, so backpatch to all supported versions. Author: Jianghua Yang <yjhjstz@gmail.com> Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d2a1aa77c25549bd0d285bdb29a89e29db4d30b2 Modified Files -------------- src/test/modules/test_ginpostinglist/test_ginpostinglist.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix copy-paste error in test_ginpostinglist @ 2026-03-24 10:25 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: John Naylor @ 2026-03-24 10:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix copy-paste error in test_ginpostinglist The check for a mismatch on the second decoded item pointer was an exact copy of the first item pointer check, comparing orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1] with decoded_itemptrs[1]. The error message also reported (0, 1) as the expected value instead of (blk, off). As a result, any decoding error in the second item pointer (where the varbyte delta encoding is exercised) would go undetected. This has been wrong since commit bde7493d1, so backpatch to all supported versions. Author: Jianghua Yang <yjhjstz@gmail.com> Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9cee8644f1aa4eb571946d65e660495fbe43e42d Modified Files -------------- src/test/modules/test_ginpostinglist/test_ginpostinglist.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix copy-paste error in test_ginpostinglist @ 2026-03-24 10:25 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: John Naylor @ 2026-03-24 10:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix copy-paste error in test_ginpostinglist The check for a mismatch on the second decoded item pointer was an exact copy of the first item pointer check, comparing orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1] with decoded_itemptrs[1]. The error message also reported (0, 1) as the expected value instead of (blk, off). As a result, any decoding error in the second item pointer (where the varbyte delta encoding is exercised) would go undetected. This has been wrong since commit bde7493d1, so backpatch to all supported versions. Author: Jianghua Yang <yjhjstz@gmail.com> Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4c0ffe6244f2f487d89e132831ba34769aa018ed Modified Files -------------- src/test/modules/test_ginpostinglist/test_ginpostinglist.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix copy-paste error in test_ginpostinglist @ 2026-03-24 10:25 John Naylor <john.naylor@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: John Naylor @ 2026-03-24 10:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix copy-paste error in test_ginpostinglist The check for a mismatch on the second decoded item pointer was an exact copy of the first item pointer check, comparing orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1] with decoded_itemptrs[1]. The error message also reported (0, 1) as the expected value instead of (blk, off). As a result, any decoding error in the second item pointer (where the varbyte delta encoding is exercised) would go undetected. This has been wrong since commit bde7493d1, so backpatch to all supported versions. Author: Jianghua Yang <yjhjstz@gmail.com> Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4dc9346531e1833ebe482828aa75d0638895c9ec Modified Files -------------- src/test/modules/test_ginpostinglist/test_ginpostinglist.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-03-24 10:25 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-03-24 10:25 pgsql: Fix copy-paste error in test_ginpostinglist John Naylor <john.naylor@postgresql.org> 2026-03-24 10:25 pgsql: Fix copy-paste error in test_ginpostinglist John Naylor <john.naylor@postgresql.org> 2026-03-24 10:25 pgsql: Fix copy-paste error in test_ginpostinglist John Naylor <john.naylor@postgresql.org> 2026-03-24 10:25 pgsql: Fix copy-paste error in test_ginpostinglist John Naylor <john.naylor@postgresql.org> 2026-03-24 10:25 pgsql: Fix copy-paste error in test_ginpostinglist John Naylor <john.naylor@postgresql.org> 2026-03-24 10:25 pgsql: Fix copy-paste error in test_ginpostinglist John Naylor <john.naylor@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox