pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Further harden tests that might use not-so-compatible tar versio 2+ messages / 1 participants [nested] [flat]
* pgsql: Further harden tests that might use not-so-compatible tar versio @ 2026-04-02 21:21 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2026-04-02 21:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Further harden tests that might use not-so-compatible tar versions. Buildfarm testing shows that OpenSUSE (and perhaps related platforms?) configures GNU tar in such a way that it'll archive sparse WAL files by default, thus triggering the pax-extension detection code added by bc30c704a. Thus, we need something similar to 852de579a but for GNU tar's option set. "--format=ustar" seems to do the trick. Moreover, the buildfarm shows that pg_verifybackup's 003_corruption.pl test script is also triggering creation of pax-format tar files on that platform. We had not noticed because those test cases all fail (intentionally) before getting to the point of trying to verify WAL data. Since that means two TAP scripts need this option-selection logic, and plausibly more will do so in future, factor it out into a subroutine in Test::Utils. We also need to back-patch the 003_corruption.pl fix into v18, where it's also failing. While at it, clean up some places where guards for $tar being empty or undefined were incomplete or even outright backwards. Presumably, we missed noticing because the set of machines that run TAP tests and don't have tar installed is empty. But if we're going to try to handle that scenario, we should do it correctly. Reported-by: Tomas Vondra <tomas@vondra.me> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/02770bea-b3f3-4015-8a43-443ae345379c@vondra.me Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ebba64c08d965550b2d034ee931a27fdf2de56b7 Modified Files -------------- src/bin/pg_verifybackup/t/003_corruption.pl | 25 ++++++++++++---- src/bin/pg_waldump/t/001_basic.pl | 14 ++------- src/test/perl/PostgreSQL/Test/Utils.pm | 44 +++++++++++++++++++++++++++++ 3 files changed, 67 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Further harden tests that might use not-so-compatible tar versio @ 2026-04-02 21:21 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2026-04-02 21:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Further harden tests that might use not-so-compatible tar versions. Buildfarm testing shows that OpenSUSE (and perhaps related platforms?) configures GNU tar in such a way that it'll archive sparse WAL files by default, thus triggering the pax-extension detection code added by bc30c704a. Thus, we need something similar to 852de579a but for GNU tar's option set. "--format=ustar" seems to do the trick. Moreover, the buildfarm shows that pg_verifybackup's 003_corruption.pl test script is also triggering creation of pax-format tar files on that platform. We had not noticed because those test cases all fail (intentionally) before getting to the point of trying to verify WAL data. Since that means two TAP scripts need this option-selection logic, and plausibly more will do so in future, factor it out into a subroutine in Test::Utils. We also need to back-patch the 003_corruption.pl fix into v18, where it's also failing. While at it, clean up some places where guards for $tar being empty or undefined were incomplete or even outright backwards. Presumably, we missed noticing because the set of machines that run TAP tests and don't have tar installed is empty. But if we're going to try to handle that scenario, we should do it correctly. Reported-by: Tomas Vondra <tomas@vondra.me> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/02770bea-b3f3-4015-8a43-443ae345379c@vondra.me Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c4b7be4ecb12a70e9bafa5353a787ba51bb4d2c6 Modified Files -------------- src/bin/pg_verifybackup/t/003_corruption.pl | 25 ++++++++++++---- src/test/perl/PostgreSQL/Test/Utils.pm | 44 +++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-04-02 21:21 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-02 21:21 pgsql: Further harden tests that might use not-so-compatible tar versio Tom Lane <tgl@sss.pgh.pa.us> 2026-04-02 21:21 pgsql: Further harden tests that might use not-so-compatible tar versio Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox