agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix WITHOUT OVERLAPS' interaction with domains. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix WITHOUT OVERLAPS' interaction with domains. @ 2026-04-07 18:45 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2026-04-07 18:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix WITHOUT OVERLAPS' interaction with domains. UNIQUE/PRIMARY KEY ... WITHOUT OVERLAPS requires the no-overlap column to be a range or multirange, but it should allow a domain over such a type too. This requires minor adjustments in both the parser and executor. In passing, fix a nearby break-instead-of-continue thinko in transformIndexConstraint. This had the effect of disabling parse-time validation of the no-overlap column's type in the context of ALTER TABLE ADD CONSTRAINT, if it follows a dropped column. We'd still complain appropriately at runtime though. Author: Jian He <jian.universality@gmail.com> Reviewed-by: Paul A Jungwirth <pj@illuminatedcomputing.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CACJufxGoAmN_0iJ=hjTG0vGpOSOyy-vYyfE+-q0AWxrq2_p5XQ@mail.gmail.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4edd6036d69ce42ac1af236f659f20daed65c8d4 Modified Files -------------- src/backend/executor/execIndexing.c | 12 ++++++-- src/backend/parser/parse_utilcmd.c | 17 +++++++---- src/test/regress/expected/without_overlaps.out | 39 ++++++++++++++++++++++++++ src/test/regress/sql/without_overlaps.sql | 31 ++++++++++++++++++++ 4 files changed, 91 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix WITHOUT OVERLAPS' interaction with domains. @ 2026-04-07 18:45 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2026-04-07 18:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix WITHOUT OVERLAPS' interaction with domains. UNIQUE/PRIMARY KEY ... WITHOUT OVERLAPS requires the no-overlap column to be a range or multirange, but it should allow a domain over such a type too. This requires minor adjustments in both the parser and executor. In passing, fix a nearby break-instead-of-continue thinko in transformIndexConstraint. This had the effect of disabling parse-time validation of the no-overlap column's type in the context of ALTER TABLE ADD CONSTRAINT, if it follows a dropped column. We'd still complain appropriately at runtime though. Author: Jian He <jian.universality@gmail.com> Reviewed-by: Paul A Jungwirth <pj@illuminatedcomputing.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CACJufxGoAmN_0iJ=hjTG0vGpOSOyy-vYyfE+-q0AWxrq2_p5XQ@mail.gmail.com Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/49f3cb453b9b86b771b0a15393893fb317e35572 Modified Files -------------- src/backend/executor/execIndexing.c | 12 ++++++-- src/backend/parser/parse_utilcmd.c | 17 +++++++---- src/test/regress/expected/without_overlaps.out | 39 ++++++++++++++++++++++++++ src/test/regress/sql/without_overlaps.sql | 31 ++++++++++++++++++++ 4 files changed, 91 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-04-07 18:45 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-07 18:45 pgsql: Fix WITHOUT OVERLAPS' interaction with domains. Tom Lane <tgl@sss.pgh.pa.us> 2026-04-07 18:45 pgsql: Fix WITHOUT OVERLAPS' interaction with domains. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox