agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Make plpgsql_trap test more robust and less resource-intensive. 6+ messages / 1 participants [nested] [flat]
* pgsql: Make plpgsql_trap test more robust and less resource-intensive. @ 2026-04-21 14:54 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-04-21 14:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make plpgsql_trap test more robust and less resource-intensive. We were using "select count(*) into x from generate_series(1, 1_000_000_000_000)" to waste one second waiting for a statement timeout trap. Aside from consuming CPU to little purpose, this could easily eat several hundred MB of temporary file space, which has been observed to cause out-of-disk-space errors in the buildfarm. Let's just use "pg_sleep(10)", which is far less resource-intensive. Also update the "when others" exception handler so that if it does ever again trap an error, it will tell us what error. The cause of these intermittent buildfarm failures had been obscure for awhile. Discussion: https://postgr.es/m/557992.1776779694@sss.pgh.pa.us Backpatch-through: 14 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/496169e525cd4fe7c8ace3a7cffb52ac87e504b9 Modified Files -------------- src/pl/plpgsql/src/expected/plpgsql_trap.out | 8 +++----- src/pl/plpgsql/src/sql/plpgsql_trap.sql | 6 ++---- 2 files changed, 5 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Make plpgsql_trap test more robust and less resource-intensive. @ 2026-04-21 14:54 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-04-21 14:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make plpgsql_trap test more robust and less resource-intensive. We were using "select count(*) into x from generate_series(1, 1_000_000_000_000)" to waste one second waiting for a statement timeout trap. Aside from consuming CPU to little purpose, this could easily eat several hundred MB of temporary file space, which has been observed to cause out-of-disk-space errors in the buildfarm. Let's just use "pg_sleep(10)", which is far less resource-intensive. Also update the "when others" exception handler so that if it does ever again trap an error, it will tell us what error. The cause of these intermittent buildfarm failures had been obscure for awhile. Discussion: https://postgr.es/m/557992.1776779694@sss.pgh.pa.us Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8a5729a8ef28e26e5e9cb6829e6b2a77feabaa69 Modified Files -------------- src/pl/plpgsql/src/expected/plpgsql_trap.out | 8 +++----- src/pl/plpgsql/src/sql/plpgsql_trap.sql | 6 ++---- 2 files changed, 5 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Make plpgsql_trap test more robust and less resource-intensive. @ 2026-04-21 14:54 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-04-21 14:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make plpgsql_trap test more robust and less resource-intensive. We were using "select count(*) into x from generate_series(1, 1_000_000_000_000)" to waste one second waiting for a statement timeout trap. Aside from consuming CPU to little purpose, this could easily eat several hundred MB of temporary file space, which has been observed to cause out-of-disk-space errors in the buildfarm. Let's just use "pg_sleep(10)", which is far less resource-intensive. Also update the "when others" exception handler so that if it does ever again trap an error, it will tell us what error. The cause of these intermittent buildfarm failures had been obscure for awhile. Discussion: https://postgr.es/m/557992.1776779694@sss.pgh.pa.us Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/81c082f51ad8834d28fdfc83b1fbe67ec4e51246 Modified Files -------------- src/pl/plpgsql/src/expected/plpgsql_trap.out | 8 +++----- src/pl/plpgsql/src/sql/plpgsql_trap.sql | 6 ++---- 2 files changed, 5 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Make plpgsql_trap test more robust and less resource-intensive. @ 2026-04-21 14:54 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-04-21 14:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make plpgsql_trap test more robust and less resource-intensive. We were using "select count(*) into x from generate_series(1, 1_000_000_000_000)" to waste one second waiting for a statement timeout trap. Aside from consuming CPU to little purpose, this could easily eat several hundred MB of temporary file space, which has been observed to cause out-of-disk-space errors in the buildfarm. Let's just use "pg_sleep(10)", which is far less resource-intensive. Also update the "when others" exception handler so that if it does ever again trap an error, it will tell us what error. The cause of these intermittent buildfarm failures had been obscure for awhile. Discussion: https://postgr.es/m/557992.1776779694@sss.pgh.pa.us Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/94f1409847e0eb9c6eaaefe3366e53b19641ccfe Modified Files -------------- src/pl/plpgsql/src/expected/plpgsql_trap.out | 8 +++----- src/pl/plpgsql/src/sql/plpgsql_trap.sql | 6 ++---- 2 files changed, 5 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Make plpgsql_trap test more robust and less resource-intensive. @ 2026-04-21 14:54 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-04-21 14:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make plpgsql_trap test more robust and less resource-intensive. We were using "select count(*) into x from generate_series(1, 1_000_000_000_000)" to waste one second waiting for a statement timeout trap. Aside from consuming CPU to little purpose, this could easily eat several hundred MB of temporary file space, which has been observed to cause out-of-disk-space errors in the buildfarm. Let's just use "pg_sleep(10)", which is far less resource-intensive. Also update the "when others" exception handler so that if it does ever again trap an error, it will tell us what error. The cause of these intermittent buildfarm failures had been obscure for awhile. Discussion: https://postgr.es/m/557992.1776779694@sss.pgh.pa.us Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5dbc5bb106c086b60617b7599deb9cd33bf20275 Modified Files -------------- src/pl/plpgsql/src/expected/plpgsql_trap.out | 8 +++----- src/pl/plpgsql/src/sql/plpgsql_trap.sql | 6 ++---- 2 files changed, 5 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Make plpgsql_trap test more robust and less resource-intensive. @ 2026-04-21 14:54 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2026-04-21 14:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make plpgsql_trap test more robust and less resource-intensive. We were using "select count(*) into x from generate_series(1, 1_000_000_000_000)" to waste one second waiting for a statement timeout trap. Aside from consuming CPU to little purpose, this could easily eat several hundred MB of temporary file space, which has been observed to cause out-of-disk-space errors in the buildfarm. Let's just use "pg_sleep(10)", which is far less resource-intensive. Also update the "when others" exception handler so that if it does ever again trap an error, it will tell us what error. The cause of these intermittent buildfarm failures had been obscure for awhile. Discussion: https://postgr.es/m/557992.1776779694@sss.pgh.pa.us Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/babf2f740d10ab1860a6985dacf7aadfa134b654 Modified Files -------------- src/pl/plpgsql/src/expected/plpgsql_trap.out | 8 +++----- src/pl/plpgsql/src/sql/plpgsql_trap.sql | 6 ++---- 2 files changed, 5 insertions(+), 9 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-04-21 14:54 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-21 14:54 pgsql: Make plpgsql_trap test more robust and less resource-intensive. Tom Lane <tgl@sss.pgh.pa.us> 2026-04-21 14:54 pgsql: Make plpgsql_trap test more robust and less resource-intensive. Tom Lane <tgl@sss.pgh.pa.us> 2026-04-21 14:54 pgsql: Make plpgsql_trap test more robust and less resource-intensive. Tom Lane <tgl@sss.pgh.pa.us> 2026-04-21 14:54 pgsql: Make plpgsql_trap test more robust and less resource-intensive. Tom Lane <tgl@sss.pgh.pa.us> 2026-04-21 14:54 pgsql: Make plpgsql_trap test more robust and less resource-intensive. Tom Lane <tgl@sss.pgh.pa.us> 2026-04-21 14:54 pgsql: Make plpgsql_trap test more robust and less resource-intensive. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox