agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
pgsql: Harmonize function parameter names for Postgres 17.
3+ messages / 1 participants
[nested] [flat]

* pgsql: Harmonize function parameter names for Postgres 17.
@ 2024-06-12 21:02 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Geoghegan @ 2024-06-12 21:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Harmonize function parameter names for Postgres 17.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions in a few places.  These
inconsistencies were all introduced during Postgres 17 development.

pg_bsd_indent still has a couple of similar inconsistencies, which I
(pgeoghegan) have left untouched for now.

This commit was written with help from clang-tidy, by mechanically
applying the same rules as similar clean-up commits (the earliest such
commit was commit 035ce1fe).

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6207f08f700ddc874765919202727fb0171b5403

Modified Files
--------------
src/backend/access/brin/brin.c                     |  6 +--
src/backend/access/heap/vacuumlazy.c               |  2 +-
src/backend/backup/basebackup_incremental.c        |  2 +-
src/backend/backup/basebackup_zstd.c               |  2 +-
src/backend/commands/tablecmds.c                   |  2 +-
src/backend/optimizer/path/joinrels.c              |  2 +-
src/backend/parser/parse_expr.c                    |  6 +--
.../libpqwalreceiver/libpqwalreceiver.c            |  2 +-
src/backend/utils/adt/jsonpath_exec.c              |  5 +--
src/bin/pg_combinebackup/copy_file.c               |  4 +-
src/bin/pg_combinebackup/reconstruct.c             |  2 +-
src/bin/pg_dump/pg_dumpall.c                       |  2 +-
src/bin/pg_dump/pg_restore.c                       |  2 +-
src/include/access/heapam.h                        |  2 +-
src/include/common/unicode_case.h                  |  6 +--
src/include/common/unicode_category.h              | 44 +++++++++++-----------
src/include/libpq/libpq.h                          |  2 +-
src/include/postmaster/postmaster.h                |  5 ++-
src/include/storage/bufmgr.h                       |  2 +-
src/include/storage/fd.h                           |  6 +--
src/include/storage/read_stream.h                  |  2 +-
src/include/storage/smgr.h                         |  4 +-
src/include/utils/guc.h                            |  4 +-
src/include/utils/jsonpath.h                       |  2 +-
src/include/utils/pg_locale.h                      |  4 +-
src/include/utils/resowner.h                       |  4 +-
src/include/utils/tuplesort.h                      |  2 +-
27 files changed, 65 insertions(+), 63 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Harmonize function parameter names for Postgres 18.
@ 2025-04-12 16:08 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Geoghegan @ 2025-04-12 16:08 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Harmonize function parameter names for Postgres 18.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions in a few places.  These
inconsistencies were all introduced during Postgres 18 development.

This commit was written with help from clang-tidy, by mechanically
applying the same rules as similar clean-up commits (the earliest such
commit was commit 035ce1fe).

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a6cab6a78ee58356967a447fa2c6414732856986

Modified Files
--------------
contrib/pg_overexplain/pg_overexplain.c            |  2 +-
contrib/postgres_fdw/postgres_fdw.c                |  2 +-
src/backend/access/gin/gininsert.c                 |  6 +++---
src/backend/commands/tablecmds.c                   |  8 ++++----
src/backend/executor/execPartition.c               |  2 +-
src/backend/nodes/queryjumblefuncs.c               |  4 ++--
src/backend/storage/buffer/bufmgr.c                |  2 +-
src/backend/storage/smgr/md.c                      |  2 +-
src/backend/utils/adt/acl.c                        |  2 +-
src/backend/utils/adt/pg_locale_builtin.c          |  8 ++++----
src/backend/utils/adt/pg_locale_icu.c              | 14 ++++----------
src/backend/utils/mmgr/mcxt.c                      |  2 +-
src/bin/scripts/reindexdb.c                        |  2 +-
src/common/unicode_case.c                          |  2 +-
src/include/commands/explain.h                     |  2 +-
src/include/libpq/oauth.h                          |  2 +-
src/include/optimizer/cost.h                       |  4 ++--
src/include/optimizer/planmain.h                   |  4 ++--
src/include/port/pg_crc32c.h                       |  2 +-
src/include/replication/slot.h                     |  2 +-
src/include/storage/lwlock.h                       |  4 ++--
src/include/storage/md.h                           |  2 +-
src/include/utils/pg_locale.h                      |  8 ++++----
src/include/utils/tuplestore.h                     |  2 +-
src/test/modules/oauth_validator/fail_validator.c  |  2 +-
src/test/modules/oauth_validator/magic_validator.c |  2 +-
src/test/modules/oauth_validator/validator.c       |  2 +-
27 files changed, 45 insertions(+), 51 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Harmonize function parameter names for Postgres 19.
@ 2026-04-22 16:47 Peter Geoghegan <pg@bowt.ie>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Geoghegan @ 2026-04-22 16:47 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Harmonize function parameter names for Postgres 19.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions in a few places.  Most of
these inconsistencies were introduced during Postgres 19 development.

This commit was written with help from clang-tidy, by mechanically
applying the same rules as similar clean-up commits (the earliest such
commit was commit 035ce1fe).

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d14f69a32a17924d93838491bc8e78a1a9b46807

Modified Files
--------------
contrib/jsonb_plperl/jsonb_plperl.c         | 2 +-
contrib/sepgsql/sepgsql.h                   | 2 +-
src/backend/access/heap/pruneheap.c         | 2 +-
src/backend/commands/propgraphcmds.c        | 2 +-
src/backend/commands/repack.c               | 2 +-
src/backend/parser/gram.y                   | 2 +-
src/backend/replication/logical/conflict.c  | 2 +-
src/backend/replication/pgrepack/pgrepack.c | 2 +-
src/backend/rewrite/rewriteGraphTable.c     | 2 +-
src/backend/storage/buffer/bufmgr.c         | 2 +-
src/bin/pg_upgrade/multixact_read_v18.h     | 2 +-
src/include/commands/repack.h               | 2 +-
src/include/executor/executor.h             | 2 +-
src/include/postmaster/datachecksum_state.h | 2 +-
src/include/replication/syncrep.h           | 2 +-
src/include/tsearch/ts_locale.h             | 2 +-
src/pl/plperl/plperl.c                      | 8 +++++---
src/timezone/localtime.c                    | 2 +-
18 files changed, 22 insertions(+), 20 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2026-04-22 16:47 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-06-12 21:02 pgsql: Harmonize function parameter names for Postgres 17. Peter Geoghegan <pg@bowt.ie>
2025-04-12 16:08 pgsql: Harmonize function parameter names for Postgres 18. Peter Geoghegan <pg@bowt.ie>
2026-04-22 16:47 pgsql: Harmonize function parameter names for Postgres 19. Peter Geoghegan <pg@bowt.ie>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox