agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix errno check based on EINTR in pg_flush_data() 4+ messages / 1 participants [nested] [flat]
* pgsql: Fix errno check based on EINTR in pg_flush_data() @ 2026-04-30 09:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-04-30 09:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix errno check based on EINTR in pg_flush_data() Upon a failure of sync_file_range(), EINTR was checked based on the returned result of the routine rather than its errno. sync_file_range() returns -1 on failure, making the check a no-op, invalidating the retry attempt in this case. Oversight in 0d369ac65004. Author: DaeMyung Kang <charsyam@gmail.com> Discussion: https://postgr.es/m/20260429151811.1810874-1-charsyam@gmail.com Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5941e7f092233adb5415b2a12addea48a97a6618 Modified Files -------------- src/backend/storage/file/fd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix errno check based on EINTR in pg_flush_data() @ 2026-04-30 09:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-04-30 09:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix errno check based on EINTR in pg_flush_data() Upon a failure of sync_file_range(), EINTR was checked based on the returned result of the routine rather than its errno. sync_file_range() returns -1 on failure, making the check a no-op, invalidating the retry attempt in this case. Oversight in 0d369ac65004. Author: DaeMyung Kang <charsyam@gmail.com> Discussion: https://postgr.es/m/20260429151811.1810874-1-charsyam@gmail.com Backpatch-through: 16 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6cb307251c5c6261286c1566496920976640108e Modified Files -------------- src/backend/storage/file/fd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix errno check based on EINTR in pg_flush_data() @ 2026-04-30 09:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-04-30 09:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix errno check based on EINTR in pg_flush_data() Upon a failure of sync_file_range(), EINTR was checked based on the returned result of the routine rather than its errno. sync_file_range() returns -1 on failure, making the check a no-op, invalidating the retry attempt in this case. Oversight in 0d369ac65004. Author: DaeMyung Kang <charsyam@gmail.com> Discussion: https://postgr.es/m/20260429151811.1810874-1-charsyam@gmail.com Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5499be3325d8d7d53795214c98495f378c501fe1 Modified Files -------------- src/backend/storage/file/fd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix errno check based on EINTR in pg_flush_data() @ 2026-04-30 09:45 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-04-30 09:45 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix errno check based on EINTR in pg_flush_data() Upon a failure of sync_file_range(), EINTR was checked based on the returned result of the routine rather than its errno. sync_file_range() returns -1 on failure, making the check a no-op, invalidating the retry attempt in this case. Oversight in 0d369ac65004. Author: DaeMyung Kang <charsyam@gmail.com> Discussion: https://postgr.es/m/20260429151811.1810874-1-charsyam@gmail.com Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3b35c10a4d503a64a6bc110de3330a337bc1a362 Modified Files -------------- src/backend/storage/file/fd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-04-30 09:45 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-30 09:45 pgsql: Fix errno check based on EINTR in pg_flush_data() Michael Paquier <michael@paquier.xyz> 2026-04-30 09:45 pgsql: Fix errno check based on EINTR in pg_flush_data() Michael Paquier <michael@paquier.xyz> 2026-04-30 09:45 pgsql: Fix errno check based on EINTR in pg_flush_data() Michael Paquier <michael@paquier.xyz> 2026-04-30 09:45 pgsql: Fix errno check based on EINTR in pg_flush_data() Michael Paquier <michael@paquier.xyz>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox