agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. 6+ messages / 1 participants [nested] [flat]
* pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. @ 2026-05-05 09:58 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2026-05-05 09:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix handling of abort-cleanup-failed connections. As connections that failed abort cleanup can't safely be further used, if a remote query tries to get such a connection, we reject it. Previously, this rejection involved dropping the connection if it was open, without accounting for the possibility of open cursors using it, causing a server crash when such an open cursor tried to use an already-dropped connection, as a cursor-handling function (create_cursor, fetch_more_data, or close_cursor) was called on a freed PGconn. To fix, delay dropping failed connections until abort cleanup of the main transaction, to ensure open cursors using such a connection can safely refer to the PGconn for it. Oversight in commit 8bf58c0d9. Reported-by: Zhibai Song <songzhibai1234@gmail.com> Diagnosed-by: Zhibai Song <songzhibai1234@gmail.com> Author: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com> Discussion: https://postgr.es/m/CAPmGK176y6JP017-Cn%2BhS9CEJx_6iVhRoYbAqzuLU4d8-XPPNg%40mail.gmail.com Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/648818ba3876fb3e43faffea729eccba969eefab Modified Files -------------- contrib/postgres_fdw/connection.c | 10 ++-- contrib/postgres_fdw/expected/postgres_fdw.out | 76 ++++++++++++++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 51 +++++++++++++++++ 3 files changed, 133 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. @ 2026-05-05 09:58 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2026-05-05 09:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix handling of abort-cleanup-failed connections. As connections that failed abort cleanup can't safely be further used, if a remote query tries to get such a connection, we reject it. Previously, this rejection involved dropping the connection if it was open, without accounting for the possibility of open cursors using it, causing a server crash when such an open cursor tried to use an already-dropped connection, as a cursor-handling function (create_cursor, fetch_more_data, or close_cursor) was called on a freed PGconn. To fix, delay dropping failed connections until abort cleanup of the main transaction, to ensure open cursors using such a connection can safely refer to the PGconn for it. Oversight in commit 8bf58c0d9. Reported-by: Zhibai Song <songzhibai1234@gmail.com> Diagnosed-by: Zhibai Song <songzhibai1234@gmail.com> Author: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com> Discussion: https://postgr.es/m/CAPmGK176y6JP017-Cn%2BhS9CEJx_6iVhRoYbAqzuLU4d8-XPPNg%40mail.gmail.com Backpatch-through: 14 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c318777da8b82cabe7c6644695385841a223f1eb Modified Files -------------- contrib/postgres_fdw/connection.c | 10 ++-- contrib/postgres_fdw/expected/postgres_fdw.out | 76 ++++++++++++++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 51 +++++++++++++++++ 3 files changed, 133 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. @ 2026-05-05 09:58 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2026-05-05 09:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix handling of abort-cleanup-failed connections. As connections that failed abort cleanup can't safely be further used, if a remote query tries to get such a connection, we reject it. Previously, this rejection involved dropping the connection if it was open, without accounting for the possibility of open cursors using it, causing a server crash when such an open cursor tried to use an already-dropped connection, as a cursor-handling function (create_cursor, fetch_more_data, or close_cursor) was called on a freed PGconn. To fix, delay dropping failed connections until abort cleanup of the main transaction, to ensure open cursors using such a connection can safely refer to the PGconn for it. Oversight in commit 8bf58c0d9. Reported-by: Zhibai Song <songzhibai1234@gmail.com> Diagnosed-by: Zhibai Song <songzhibai1234@gmail.com> Author: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com> Discussion: https://postgr.es/m/CAPmGK176y6JP017-Cn%2BhS9CEJx_6iVhRoYbAqzuLU4d8-XPPNg%40mail.gmail.com Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/af8f9248fbe72f8c19f4f20daf38495afdd0a26b Modified Files -------------- contrib/postgres_fdw/connection.c | 10 ++-- contrib/postgres_fdw/expected/postgres_fdw.out | 76 ++++++++++++++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 51 +++++++++++++++++ 3 files changed, 133 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. @ 2026-05-05 09:58 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2026-05-05 09:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix handling of abort-cleanup-failed connections. As connections that failed abort cleanup can't safely be further used, if a remote query tries to get such a connection, we reject it. Previously, this rejection involved dropping the connection if it was open, without accounting for the possibility of open cursors using it, causing a server crash when such an open cursor tried to use an already-dropped connection, as a cursor-handling function (create_cursor, fetch_more_data, or close_cursor) was called on a freed PGconn. To fix, delay dropping failed connections until abort cleanup of the main transaction, to ensure open cursors using such a connection can safely refer to the PGconn for it. Oversight in commit 8bf58c0d9. Reported-by: Zhibai Song <songzhibai1234@gmail.com> Diagnosed-by: Zhibai Song <songzhibai1234@gmail.com> Author: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com> Discussion: https://postgr.es/m/CAPmGK176y6JP017-Cn%2BhS9CEJx_6iVhRoYbAqzuLU4d8-XPPNg%40mail.gmail.com Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1352651c21ab5d5bf7aa85f1add0c39ad174a557 Modified Files -------------- contrib/postgres_fdw/connection.c | 10 ++-- contrib/postgres_fdw/expected/postgres_fdw.out | 76 ++++++++++++++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 51 +++++++++++++++++ 3 files changed, 133 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. @ 2026-05-05 09:58 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2026-05-05 09:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix handling of abort-cleanup-failed connections. As connections that failed abort cleanup can't safely be further used, if a remote query tries to get such a connection, we reject it. Previously, this rejection involved dropping the connection if it was open, without accounting for the possibility of open cursors using it, causing a server crash when such an open cursor tried to use an already-dropped connection, as a cursor-handling function (create_cursor, fetch_more_data, or close_cursor) was called on a freed PGconn. To fix, delay dropping failed connections until abort cleanup of the main transaction, to ensure open cursors using such a connection can safely refer to the PGconn for it. Oversight in commit 8bf58c0d9. Reported-by: Zhibai Song <songzhibai1234@gmail.com> Diagnosed-by: Zhibai Song <songzhibai1234@gmail.com> Author: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com> Discussion: https://postgr.es/m/CAPmGK176y6JP017-Cn%2BhS9CEJx_6iVhRoYbAqzuLU4d8-XPPNg%40mail.gmail.com Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/34c18a22556e5274c6c1ab708fe01e47eb02b6a1 Modified Files -------------- contrib/postgres_fdw/connection.c | 10 ++-- contrib/postgres_fdw/expected/postgres_fdw.out | 76 ++++++++++++++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 51 +++++++++++++++++ 3 files changed, 133 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. @ 2026-05-05 09:58 Etsuro Fujita <efujita@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Etsuro Fujita @ 2026-05-05 09:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org postgres_fdw: Fix handling of abort-cleanup-failed connections. As connections that failed abort cleanup can't safely be further used, if a remote query tries to get such a connection, we reject it. Previously, this rejection involved dropping the connection if it was open, without accounting for the possibility of open cursors using it, causing a server crash when such an open cursor tried to use an already-dropped connection, as a cursor-handling function (create_cursor, fetch_more_data, or close_cursor) was called on a freed PGconn. To fix, delay dropping failed connections until abort cleanup of the main transaction, to ensure open cursors using such a connection can safely refer to the PGconn for it. Oversight in commit 8bf58c0d9. Reported-by: Zhibai Song <songzhibai1234@gmail.com> Diagnosed-by: Zhibai Song <songzhibai1234@gmail.com> Author: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com> Discussion: https://postgr.es/m/CAPmGK176y6JP017-Cn%2BhS9CEJx_6iVhRoYbAqzuLU4d8-XPPNg%40mail.gmail.com Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fd5b36ab1891b6fa44d4a039ede518b952129855 Modified Files -------------- contrib/postgres_fdw/connection.c | 10 ++-- contrib/postgres_fdw/expected/postgres_fdw.out | 76 ++++++++++++++++++++++++++ contrib/postgres_fdw/sql/postgres_fdw.sql | 51 +++++++++++++++++ 3 files changed, 133 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-05-05 09:58 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-05-05 09:58 pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. Etsuro Fujita <efujita@postgresql.org> 2026-05-05 09:58 pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. Etsuro Fujita <efujita@postgresql.org> 2026-05-05 09:58 pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. Etsuro Fujita <efujita@postgresql.org> 2026-05-05 09:58 pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. Etsuro Fujita <efujita@postgresql.org> 2026-05-05 09:58 pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. Etsuro Fujita <efujita@postgresql.org> 2026-05-05 09:58 pgsql: postgres_fdw: Fix handling of abort-cleanup-failed connections. Etsuro Fujita <efujita@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox