public inbox for [email protected]  
help / color / mirror / Atom feed
From: Noah Misch <[email protected]>
To: [email protected]
Subject: pgsql: Add pg_add_size_overflow() and friends
Date: Mon, 11 May 2026 12:19:37 +0000
Message-ID: <[email protected]> (raw)

Add pg_add_size_overflow() and friends

Commit 600086f47 added (several bespoke copies of) size_t addition with
overflow checks to libpq. Move this to common/int.h, along with
its subtraction and multiplication counterparts.

pg_neg_size_overflow() is intentionally omitted; I'm not sure we should
add SSIZE_MAX to win32_port.h for the sake of a function with no
callers.

Back-patch of commit 8934f2136, done now because pg_add_size_overflow()
and friends are needed more widely for security fixes.

Author: Jacob Champion <[email protected]>
Reviewed-by: Chao Li <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Discussion: https://postgr.es/m/CAOYmi%2B%3D%2BpqUd2MUitvgW1pAJuXgG_TKCVc3_Ek7pe8z9nkf%2BAg%40mail.gmail.com
Backpatch-through: 14-18
Security: CVE-2026-6473

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c7fb9f765cc5d08b2edb242a2b40d5e8b3c88668
Author: Tom Lane <[email protected]>

Modified Files
--------------
src/include/common/int.h            | 67 +++++++++++++++++++++++++++++++++++++
src/interfaces/libpq/fe-exec.c      | 44 +++++++-----------------
src/interfaces/libpq/fe-print.c     | 36 +++++---------------
src/interfaces/libpq/fe-protocol3.c | 27 +++------------
4 files changed, 91 insertions(+), 83 deletions(-)



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Add pg_add_size_overflow() and friends
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox