public inbox for [email protected]
help / color / mirror / Atom feedpgsql: Advance restart_lsn more eagerly in LogicalConfirmReceivedLocati
3+ messages / 2 participants
[nested] [flat]
* pgsql: Advance restart_lsn more eagerly in LogicalConfirmReceivedLocati
@ 2026-05-29 19:10 Álvaro Herrera <[email protected]>
2026-06-01 18:32 ` Re: pgsql: Advance restart_lsn more eagerly in LogicalConfirmReceivedLocati Álvaro Herrera <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Álvaro Herrera @ 2026-05-29 19:10 UTC (permalink / raw)
To: [email protected]
Advance restart_lsn more eagerly in LogicalConfirmReceivedLocation
The existing logic computed an updated replicationSlotMinLSN from all
slots' restart_lsn only when catalog_xmin also advanced. This is not a
problem in normal (non-repack) cases, because catalog_xmin changes
pretty frequently, so the recomputation is triggered frequently enough.
However, REPACK does not currently change its catalog snapshot, so that
doesn't work very well if no other replication slot is being used.
(After this commit, we still don't recycle WAL properly for REPACK,
because its background worker is not advancing its restart_lsn either;
that will be fixed in a separate commit. However, this preexisting
problem in older code is logically separate from that one.)
Author: Zhijie Hou <[email protected]>
Reviewed-by: Amit Kapila <[email protected]>
Discussion: https://postgr.es/m/TY4PR01MB17718B44164522D0798F8E898940A2@TY4PR01MB17718.jpnprd01.prod.outlook.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/38470c2c1ea7dc0971d7abf65ef1dde80824ef43
Modified Files
--------------
src/backend/replication/logical/logical.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Advance restart_lsn more eagerly in LogicalConfirmReceivedLocati
2026-05-29 19:10 pgsql: Advance restart_lsn more eagerly in LogicalConfirmReceivedLocati Álvaro Herrera <[email protected]>
@ 2026-06-01 18:32 ` Álvaro Herrera <[email protected]>
2026-06-02 03:10 ` Re: pgsql: Advance restart_lsn more eagerly in LogicalConfirmReceivedLocati Chao Li <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Álvaro Herrera @ 2026-06-01 18:32 UTC (permalink / raw)
To: [email protected]; +Cc: Chao Li <[email protected]>; Zhijie Hou (Fujitsu) <[email protected]>
On 2026-May-29, Álvaro Herrera wrote:
> Advance restart_lsn more eagerly in LogicalConfirmReceivedLocation
My apologies -- I failed to attribute co-authorship of this patch to Chao
Li per the other thread,
https://www.postgresql.org/message-id/D8D9F770-DAA2-482C-A7E0-F87E5104C13E%40gmail.com
Generally speaking, it would be helpful for patch authors to add the
appropriate "Discussion:", "Author:" and "Reviewed-by:" trailers to
commit messages. I tend to rewrite commit messages almost entirely
before pushing, but I'd normally preserve the trailers.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Advance restart_lsn more eagerly in LogicalConfirmReceivedLocati
2026-05-29 19:10 pgsql: Advance restart_lsn more eagerly in LogicalConfirmReceivedLocati Álvaro Herrera <[email protected]>
2026-06-01 18:32 ` Re: pgsql: Advance restart_lsn more eagerly in LogicalConfirmReceivedLocati Álvaro Herrera <[email protected]>
@ 2026-06-02 03:10 ` Chao Li <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Chao Li @ 2026-06-02 03:10 UTC (permalink / raw)
To: Álvaro Herrera <[email protected]>; +Cc: [email protected]; Zhijie Hou (Fujitsu) <[email protected]>
> On Jun 2, 2026, at 02:32, Álvaro Herrera <[email protected]> wrote:
>
> On 2026-May-29, Álvaro Herrera wrote:
>
>> Advance restart_lsn more eagerly in LogicalConfirmReceivedLocation
>
> My apologies -- I failed to attribute co-authorship of this patch to Chao
> Li per the other thread,
> https://www.postgresql.org/message-id/D8D9F770-DAA2-482C-A7E0-F87E5104C13E%40gmail.com
>
No worries, that’s not a problem at all.
> Generally speaking, it would be helpful for patch authors to add the
> appropriate "Discussion:", "Author:" and "Reviewed-by:" trailers to
> commit messages. I tend to rewrite commit messages almost entirely
> before pushing, but I'd normally preserve the trailers.
>
Yes, I agree. I usually try to keep those trailers up to date in my patches, as I think that may make things a bit easier for committers.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-06-02 03:10 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-05-29 19:10 pgsql: Advance restart_lsn more eagerly in LogicalConfirmReceivedLocati Álvaro Herrera <[email protected]>
2026-06-01 18:32 ` Álvaro Herrera <[email protected]>
2026-06-02 03:10 ` Chao Li <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox