agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Don't cast off_t to 32-bit type for output, bug fix 6+ messages / 1 participants [nested] [flat]
* pgsql: Don't cast off_t to 32-bit type for output, bug fix @ 2026-07-01 08:00 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-07-01 08:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't cast off_t to 32-bit type for output, bug fix off_t is most likely a 64-bit integer, so casting it to a 32-bit type for output could lose data. There are more issues like this in the tree, but this is an instance where this could actually happen in practice, since base backups are routinely larger than 4 GB. So this is separated out as a bug fix. Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e8f851d61727babe2ce162292b21e6afc89ca65f Modified Files -------------- src/backend/backup/basebackup_server.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't cast off_t to 32-bit type for output, bug fix @ 2026-07-01 08:00 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-07-01 08:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't cast off_t to 32-bit type for output, bug fix off_t is most likely a 64-bit integer, so casting it to a 32-bit type for output could lose data. There are more issues like this in the tree, but this is an instance where this could actually happen in practice, since base backups are routinely larger than 4 GB. So this is separated out as a bug fix. Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d4e2280b7e4872b603592ae521320b9d1c4e6b24 Modified Files -------------- src/backend/backup/basebackup_server.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't cast off_t to 32-bit type for output, bug fix @ 2026-07-01 08:00 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-07-01 08:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't cast off_t to 32-bit type for output, bug fix off_t is most likely a 64-bit integer, so casting it to a 32-bit type for output could lose data. There are more issues like this in the tree, but this is an instance where this could actually happen in practice, since base backups are routinely larger than 4 GB. So this is separated out as a bug fix. Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/215ab56119e02ec77b3bd417ccf5334f9259bb52 Modified Files -------------- src/backend/backup/basebackup_server.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't cast off_t to 32-bit type for output, bug fix @ 2026-07-01 08:00 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-07-01 08:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't cast off_t to 32-bit type for output, bug fix off_t is most likely a 64-bit integer, so casting it to a 32-bit type for output could lose data. There are more issues like this in the tree, but this is an instance where this could actually happen in practice, since base backups are routinely larger than 4 GB. So this is separated out as a bug fix. Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4d99e6ed640e3a214875b814d489c4d8ce8f77b1 Modified Files -------------- src/backend/backup/basebackup_server.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't cast off_t to 32-bit type for output, bug fix @ 2026-07-01 08:00 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-07-01 08:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't cast off_t to 32-bit type for output, bug fix off_t is most likely a 64-bit integer, so casting it to a 32-bit type for output could lose data. There are more issues like this in the tree, but this is an instance where this could actually happen in practice, since base backups are routinely larger than 4 GB. So this is separated out as a bug fix. Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/67235209ca05348bf388db731cee64895428b164 Modified Files -------------- src/backend/backup/basebackup_server.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Don't cast off_t to 32-bit type for output, bug fix @ 2026-07-01 08:00 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 6+ messages in thread From: Peter Eisentraut @ 2026-07-01 08:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't cast off_t to 32-bit type for output, bug fix off_t is most likely a 64-bit integer, so casting it to a 32-bit type for output could lose data. There are more issues like this in the tree, but this is an instance where this could actually happen in practice, since base backups are routinely larger than 4 GB. So this is separated out as a bug fix. Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c754d9311509e3d3d2f22d264151e040e7a2d832 Modified Files -------------- src/backend/backup/basebackup_server.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-07-01 08:00 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-07-01 08:00 pgsql: Don't cast off_t to 32-bit type for output, bug fix Peter Eisentraut <peter@eisentraut.org> 2026-07-01 08:00 pgsql: Don't cast off_t to 32-bit type for output, bug fix Peter Eisentraut <peter@eisentraut.org> 2026-07-01 08:00 pgsql: Don't cast off_t to 32-bit type for output, bug fix Peter Eisentraut <peter@eisentraut.org> 2026-07-01 08:00 pgsql: Don't cast off_t to 32-bit type for output, bug fix Peter Eisentraut <peter@eisentraut.org> 2026-07-01 08:00 pgsql: Don't cast off_t to 32-bit type for output, bug fix Peter Eisentraut <peter@eisentraut.org> 2026-07-01 08:00 pgsql: Don't cast off_t to 32-bit type for output, bug fix Peter Eisentraut <peter@eisentraut.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox