agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
pgsql: amcheck: Fix memory leak with gin_index_check()
3+ messages / 1 participants
[nested] [flat]

* pgsql: amcheck: Fix memory leak with gin_index_check()
@ 2026-07-06 00:32  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 3+ messages in thread

From: Michael Paquier @ 2026-07-06 00:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

amcheck: Fix memory leak with gin_index_check()

"prev_tuple" was overwritten with a new tuple coming from
CopyIndexTuple() on each loop, leaking memory for every tuple processed
on entry tree pages.  The function uses a dedicated memory context, but
this could leave unused large areas of memory while processing a large
GIN index, the larger the worse.

Oversight in 14ffaece0fb5.

Author: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Discussion: https://postgr.es/m/CALdSSPjTS6TYe5=5NfMUBYZyQu5cn=ABL6K5_OZjzGWqnwXeBw@mail.gmail.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e939332c6b1c7750f161424d8fbf8989b11cb5f6

Modified Files
--------------
contrib/amcheck/verify_gin.c | 3 +++
1 file changed, 3 insertions(+)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: amcheck: Fix memory leak with gin_index_check()
@ 2026-07-06 00:32  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 3+ messages in thread

From: Michael Paquier @ 2026-07-06 00:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

amcheck: Fix memory leak with gin_index_check()

"prev_tuple" was overwritten with a new tuple coming from
CopyIndexTuple() on each loop, leaking memory for every tuple processed
on entry tree pages.  The function uses a dedicated memory context, but
this could leave unused large areas of memory while processing a large
GIN index, the larger the worse.

Oversight in 14ffaece0fb5.

Author: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Discussion: https://postgr.es/m/CALdSSPjTS6TYe5=5NfMUBYZyQu5cn=ABL6K5_OZjzGWqnwXeBw@mail.gmail.com
Backpatch-through: 18

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/80cfd8aef645295aceafd2aa98912c64edd06394

Modified Files
--------------
contrib/amcheck/verify_gin.c | 3 +++
1 file changed, 3 insertions(+)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: amcheck: Fix memory leak with gin_index_check()
@ 2026-07-06 00:32  Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 3+ messages in thread

From: Michael Paquier @ 2026-07-06 00:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

amcheck: Fix memory leak with gin_index_check()

"prev_tuple" was overwritten with a new tuple coming from
CopyIndexTuple() on each loop, leaking memory for every tuple processed
on entry tree pages.  The function uses a dedicated memory context, but
this could leave unused large areas of memory while processing a large
GIN index, the larger the worse.

Oversight in 14ffaece0fb5.

Author: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Ewan Young <kdbase.hack@gmail.com>
Discussion: https://postgr.es/m/CALdSSPjTS6TYe5=5NfMUBYZyQu5cn=ABL6K5_OZjzGWqnwXeBw@mail.gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1f8ab91c11ebf3d6521e2c9d67e321b1256f364c

Modified Files
--------------
contrib/amcheck/verify_gin.c | 3 +++
1 file changed, 3 insertions(+)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2026-07-06 00:32 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-06 00:32 pgsql: amcheck: Fix memory leak with gin_index_check() Michael Paquier <michael@paquier.xyz>
2026-07-06 00:32 pgsql: amcheck: Fix memory leak with gin_index_check() Michael Paquier <michael@paquier.xyz>
2026-07-06 00:32 pgsql: amcheck: Fix memory leak with gin_index_check() Michael Paquier <michael@paquier.xyz>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox