agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Update GROUP BY ALL comments about window functions 2+ messages / 1 participants [nested] [flat]
* pgsql: Update GROUP BY ALL comments about window functions @ 2026-07-07 06:54 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2026-07-07 06:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Update GROUP BY ALL comments about window functions When GROUP BY ALL was added in commit ef38a4d9756, the SQL standard working draft was silent on what to do with window functions. This has now been fixed in the SQL standard working draft. Update the documentation and code comments about that. Also make the documentation more specific that we are only talking about aggregate functions referring to the same query level, which is another thing that has been made more precise in the SQL standard working draft since. The PostgreSQL implementation was already doing the right thing for both aspects, so no functionality changes. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/CAHM0NXjz0kDwtzoe-fnHAqPB1qA8_VJN0XAmCgUZ%2BiPnvP5LbA%40m... Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/2ce74583652fb4cd29299a220ff31043adf5c96e Modified Files -------------- doc/src/sgml/queries.sgml | 2 +- doc/src/sgml/ref/select.sgml | 3 ++- src/backend/parser/parse_clause.c | 4 +--- 3 files changed, 4 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Update GROUP BY ALL comments about window functions @ 2026-07-07 06:54 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2026-07-07 06:54 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Update GROUP BY ALL comments about window functions When GROUP BY ALL was added in commit ef38a4d9756, the SQL standard working draft was silent on what to do with window functions. This has now been fixed in the SQL standard working draft. Update the documentation and code comments about that. Also make the documentation more specific that we are only talking about aggregate functions referring to the same query level, which is another thing that has been made more precise in the SQL standard working draft since. The PostgreSQL implementation was already doing the right thing for both aspects, so no functionality changes. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/CAHM0NXjz0kDwtzoe-fnHAqPB1qA8_VJN0XAmCgUZ%2BiPnvP5LbA%40m... Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7f0998f87b08e325ab65b1355464a1430042b9aa Modified Files -------------- doc/src/sgml/queries.sgml | 2 +- doc/src/sgml/ref/select.sgml | 3 ++- src/backend/parser/parse_clause.c | 4 +--- 3 files changed, 4 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-07-07 06:54 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-07-07 06:54 pgsql: Update GROUP BY ALL comments about window functions Peter Eisentraut <peter@eisentraut.org> 2026-07-07 06:54 pgsql: Update GROUP BY ALL comments about window functions Peter Eisentraut <peter@eisentraut.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox