public inbox for [email protected]  

help / color / mirror / Atom feed

From: Heikki Linnakangas <[email protected]>
To: [email protected]
Subject: pgsql: Remove unused tuple fetch in speculative completion
Date: Tue, 07 Jul 2026 22:17:23 +0000
Message-ID: <[email protected]> (raw)

Remove unused tuple fetch in speculative completion

heapam_tuple_complete_speculative() fetched a tuple from the slot only
to free it immediately afterwards, without ever using it.

The function only needs slot->tts_tid to complete or abort the
speculative insertion, so remove the unnecessary fetch and pfree().

Author: Chao Li <[email protected]>
Reviewed-by: Japin Li <[email protected]>
Reviewed-by: Xuneng Zhou <[email protected]>
Reviewed-by: Surya Poondla <[email protected]>
Discussion: https://www.postgresql.org/message-id/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7258c891d4cabd366e4529484f2ad6e99234db48

Modified Files
--------------
src/backend/access/heap/heapam_handler.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Remove unused tuple fetch in speculative completion
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox