public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: [email protected]
Subject: pgsql: Fix more Datum conversion inconsistencies
Date: Wed, 08 Jul 2026 04:23:03 +0000
Message-ID: <[email protected]> (raw)

Fix more Datum conversion inconsistencies

This is a continuation of the work done in ac59a90bef45.  The
*GetDatum() macros for output should match with what the SQL functions
use as DatumGet*() in input.

Aleksander has spotted some of the areas patched here, for pageinspect.
I have spotted the rest while digging into the state of the tree.

There is no behavior change after this commit, since all the affected
values are small enough that the signed bit is never used.

Author: Aleksander Alekseev <[email protected]>
Author: Michael Paquier <[email protected]>
Discussion: https://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d92e98340fcb4c3ef728b3e8204573bdc86098f7

Modified Files
--------------
contrib/pageinspect/brinfuncs.c               |  8 ++++----
contrib/pageinspect/btreefuncs.c              |  2 +-
contrib/pageinspect/ginfuncs.c                |  2 +-
contrib/pageinspect/gistfuncs.c               |  4 ++--
contrib/pageinspect/heapfuncs.c               | 18 +++++++++---------
contrib/pageinspect/rawpage.c                 | 14 +++++++-------
contrib/pg_logicalinspect/pg_logicalinspect.c |  8 ++++----
contrib/pg_walinspect/pg_walinspect.c         | 14 +++++++-------
contrib/pgstattuple/pgstatindex.c             |  2 +-
src/backend/access/gin/ginlogic.c             |  6 +++---
src/backend/access/transam/xlogfuncs.c        |  2 +-
src/backend/catalog/pg_proc.c                 |  4 ++--
src/backend/utils/adt/lockfuncs.c             | 10 +++++-----
13 files changed, 47 insertions(+), 47 deletions(-)



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Fix more Datum conversion inconsistencies
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox