public inbox for [email protected]  
help / color / mirror / Atom feed
pgsql: Move WAIT_FOR_WAL_* wait events from Client to IPC class
2+ messages / 1 participants
[nested] [flat]

* pgsql: Move WAIT_FOR_WAL_* wait events from Client to IPC class
@ 2026-07-08 18:00  Alexander Korotkov <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Alexander Korotkov @ 2026-07-08 18:00 UTC (permalink / raw)
  To: [email protected]

Move WAIT_FOR_WAL_* wait events from Client to IPC class

WAIT_FOR_WAL_FLUSH, WAIT_FOR_WAL_REPLAY, and WAIT_FOR_WAL_WRITE were
placed in the WaitEventClient class.  But WaitEventClient is about
waiting for a socket to become readable or writable, while these events
have other delay sources as well: local fsync and local replay, which
may be disk- or CPU-bound.  WaitEventIPC is a better fit, so move them
there.

Reported-by: Noah Misch <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/56fa044d15e8b06d84889f06f5def21a62fb86a3

Modified Files
--------------
src/backend/utils/activity/wait_event_names.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Move WAIT_FOR_WAL_* wait events from Client to IPC class
@ 2026-07-08 18:00  Alexander Korotkov <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Alexander Korotkov @ 2026-07-08 18:00 UTC (permalink / raw)
  To: [email protected]

Move WAIT_FOR_WAL_* wait events from Client to IPC class

WAIT_FOR_WAL_FLUSH, WAIT_FOR_WAL_REPLAY, and WAIT_FOR_WAL_WRITE were
placed in the WaitEventClient class.  But WaitEventClient is about
waiting for a socket to become readable or writable, while these events
have other delay sources as well: local fsync and local replay, which
may be disk- or CPU-bound.  WaitEventIPC is a better fit, so move them
there.

Reported-by: Noah Misch <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/306d7680f084cf320841128f23d888294ecba6cd

Modified Files
--------------
src/backend/utils/activity/wait_event_names.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2026-07-08 18:00 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-08 18:00 pgsql: Move WAIT_FOR_WAL_* wait events from Client to IPC class Alexander Korotkov <[email protected]>
2026-07-08 18:00 pgsql: Move WAIT_FOR_WAL_* wait events from Client to IPC class Alexander Korotkov <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox