agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
pgsql: postgres_fdw: Mark statistics import helpers as static
2+ messages / 1 participants
[nested] [flat]

* pgsql: postgres_fdw: Mark statistics import helpers as static
@ 2026-07-10 11:37 Fujii Masao <fujii@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Fujii Masao @ 2026-07-10 11:37 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

postgres_fdw: Mark statistics import helpers as static

The set_*_arg helper functions in postgres_fdw.c are declared
static, but their definitions omitted the static keyword. Add it to
make their file-local scope explicit and keep the declarations and
definitions consistent.

Also fix a couple of nearby comment typos.

This is a followup to commit 54cd6fc8317.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Etsuro Fujita <etsuro.fujita@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwGjcQ4SwHMUQ9P8UYQ7iLKL1QE3uLSdONToQ1MrzpUUoQ@mail.gmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/701f021b680ec33a799022d31b574fbcd618a40f

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c      | 12 ++++++------
src/backend/statistics/attribute_stats.c |  2 +-
src/backend/statistics/relation_stats.c  |  2 +-
3 files changed, 8 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: postgres_fdw: Mark statistics import helpers as static
@ 2026-07-10 11:38 Fujii Masao <fujii@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Fujii Masao @ 2026-07-10 11:38 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

postgres_fdw: Mark statistics import helpers as static

The set_*_arg helper functions in postgres_fdw.c are declared
static, but their definitions omitted the static keyword. Add it to
make their file-local scope explicit and keep the declarations and
definitions consistent.

Also fix a couple of nearby comment typos.

This is a followup to commit 54cd6fc8317.

Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Etsuro Fujita <etsuro.fujita@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwGjcQ4SwHMUQ9P8UYQ7iLKL1QE3uLSdONToQ1MrzpUUoQ@mail.gmail.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2bbec7c49a6c872fdfdddf7ff9ea9dc9cebaef40

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c      | 12 ++++++------
src/backend/statistics/attribute_stats.c |  2 +-
src/backend/statistics/relation_stats.c  |  2 +-
3 files changed, 8 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2026-07-10 11:38 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-10 11:37 pgsql: postgres_fdw: Mark statistics import helpers as static Fujii Masao <fujii@postgresql.org>
2026-07-10 11:38 pgsql: postgres_fdw: Mark statistics import helpers as static Fujii Masao <fujii@postgresql.org>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox