agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedpgsql: Update FSM after updating VM on-access
4+ messages / 2 participants
[nested] [flat]
* pgsql: Update FSM after updating VM on-access
@ 2026-07-10 22:21 Melanie Plageman <melanieplageman@gmail.com>
2026-07-11 11:47 ` Re: pgsql: Update FSM after updating VM on-access Jelte Fennema-Nio <postgres@jeltef.nl>
0 siblings, 1 reply; 4+ messages in thread
From: Melanie Plageman @ 2026-07-10 22:21 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Update FSM after updating VM on-access
b46e1e54d078de allowed setting the VM while on-access pruning, but it
neglected to update the freespace map. Once the page was all-visible,
vacuum could skip it, leading to stale freespace map values and,
effectively, bloat. Fix it by updating the FSM if we updated the VM.
Author: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>
Discussion: https://postgr.es/m/flat/CAAKRu_b2StZrEC%3DHmW8LePuQbczyFRnfs8qTAJwn_%3DW76-y24w%40mail.gmail.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e9eaeb04248a8b2cc977440caa1b72174c108c14
Modified Files
--------------
src/backend/access/heap/pruneheap.c | 26 +++++++++++++++++++++++---
1 file changed, 23 insertions(+), 3 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Update FSM after updating VM on-access
2026-07-10 22:21 pgsql: Update FSM after updating VM on-access Melanie Plageman <melanieplageman@gmail.com>
@ 2026-07-11 11:47 ` Jelte Fennema-Nio <postgres@jeltef.nl>
2026-07-13 13:31 ` Re: pgsql: Update FSM after updating VM on-access Melanie Plageman <melanieplageman@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Jelte Fennema-Nio @ 2026-07-11 11:47 UTC (permalink / raw)
To: Melanie Plageman <melanieplageman@gmail.com>; +Cc: pgsql-committers@lists.postgresql.org
On Sat, 11 Jul 2026 at 00:21, Melanie Plageman
<melanieplageman@gmail.com> wrote:
> Backpatch-through: 19
Was this intentionally only committed on REL_19_STABLE and not to master?
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Update FSM after updating VM on-access
2026-07-10 22:21 pgsql: Update FSM after updating VM on-access Melanie Plageman <melanieplageman@gmail.com>
2026-07-11 11:47 ` Re: pgsql: Update FSM after updating VM on-access Jelte Fennema-Nio <postgres@jeltef.nl>
@ 2026-07-13 13:31 ` Melanie Plageman <melanieplageman@gmail.com>
2026-07-13 21:43 ` Re: pgsql: Update FSM after updating VM on-access Jelte Fennema-Nio <postgres@jeltef.nl>
0 siblings, 1 reply; 4+ messages in thread
From: Melanie Plageman @ 2026-07-13 13:31 UTC (permalink / raw)
To: Jelte Fennema-Nio <postgres@jeltef.nl>; +Cc: pgsql-committers@lists.postgresql.org
On Sat, Jul 11, 2026 at 7:48 AM Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>
> On Sat, 11 Jul 2026 at 00:21, Melanie Plageman
> <melanieplageman@gmail.com> wrote:
> > Backpatch-through: 19
>
> Was this intentionally only committed on REL_19_STABLE and not to master?
It's on master as eed6c0d33e09c53, and I pushed there first. Did I
miss something?
- Melanie
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Update FSM after updating VM on-access
2026-07-10 22:21 pgsql: Update FSM after updating VM on-access Melanie Plageman <melanieplageman@gmail.com>
2026-07-11 11:47 ` Re: pgsql: Update FSM after updating VM on-access Jelte Fennema-Nio <postgres@jeltef.nl>
2026-07-13 13:31 ` Re: pgsql: Update FSM after updating VM on-access Melanie Plageman <melanieplageman@gmail.com>
@ 2026-07-13 21:43 ` Jelte Fennema-Nio <postgres@jeltef.nl>
0 siblings, 0 replies; 4+ messages in thread
From: Jelte Fennema-Nio @ 2026-07-13 21:43 UTC (permalink / raw)
To: Melanie Plageman <melanieplageman@gmail.com>; +Cc: pgsql-committers@lists.postgresql.org
On Mon, Jul 13, 2026, 15:31 Melanie Plageman <melanieplageman@gmail.com>
wrote:
> It's on master as eed6c0d33e09c53, and I pushed there first. Did I
> miss something?
>
Hmm, yeah I see it now... I never received the matching pgsql-committers
email, though. And I don't see it in the archives for pgsql-committers list
either. So let's chalk it up to an infra issue. Sorry for the noise.
>
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-07-13 21:43 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-10 22:21 pgsql: Update FSM after updating VM on-access Melanie Plageman <melanieplageman@gmail.com>
2026-07-11 11:47 ` Jelte Fennema-Nio <postgres@jeltef.nl>
2026-07-13 13:31 ` Melanie Plageman <melanieplageman@gmail.com>
2026-07-13 21:43 ` Jelte Fennema-Nio <postgres@jeltef.nl>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox