agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedpgsql: Fix argument names in pg_clear_attribute_stats() errors
3+ messages / 1 participants
[nested] [flat]
* pgsql: Fix argument names in pg_clear_attribute_stats() errors
@ 2026-07-15 12:25 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: Fujii Masao @ 2026-07-15 12:25 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix argument names in pg_clear_attribute_stats() errors
pg_clear_attribute_stats() checks its required arguments manually
because the function is not strict. Previously, when schemaname or
relname was passed as NULL, the error incorrectly reported the
argument name as "relation" in both cases:
ERROR: argument "relation" must not be null
This was misleading, especially for schemaname, and inconsistent with
the function's SQL-visible argument names.
The cause is that cleararginfo[] in attribute_stats.c used
"relation" for both the schema-name and relation-name arguments.
This commit fixes the issue by using "schemaname" and "relname" instead,
matching the function's declared argument names so that the error reports
the correct argument name.
Backpatch to v18, where pg_clear_attribute_stats() was introduced.
Author: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/4bf66c5e-8dd7-4ef3-8691-db67ecff6f16@tantorlabs.com
Backpatch-through: 18
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/11ed011ae22a620b01a43634b5eea2f9af5c709c
Modified Files
--------------
src/backend/statistics/attribute_stats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix argument names in pg_clear_attribute_stats() errors
@ 2026-07-15 12:26 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: Fujii Masao @ 2026-07-15 12:26 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix argument names in pg_clear_attribute_stats() errors
pg_clear_attribute_stats() checks its required arguments manually
because the function is not strict. Previously, when schemaname or
relname was passed as NULL, the error incorrectly reported the
argument name as "relation" in both cases:
ERROR: argument "relation" must not be null
This was misleading, especially for schemaname, and inconsistent with
the function's SQL-visible argument names.
The cause is that cleararginfo[] in attribute_stats.c used
"relation" for both the schema-name and relation-name arguments.
This commit fixes the issue by using "schemaname" and "relname" instead,
matching the function's declared argument names so that the error reports
the correct argument name.
Backpatch to v18, where pg_clear_attribute_stats() was introduced.
Author: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/4bf66c5e-8dd7-4ef3-8691-db67ecff6f16@tantorlabs.com
Backpatch-through: 18
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/173ea84dfdc96390ce37a3918aa660a15c4734a9
Modified Files
--------------
src/backend/statistics/attribute_stats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix argument names in pg_clear_attribute_stats() errors
@ 2026-07-15 12:26 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 3+ messages in thread
From: Fujii Masao @ 2026-07-15 12:26 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix argument names in pg_clear_attribute_stats() errors
pg_clear_attribute_stats() checks its required arguments manually
because the function is not strict. Previously, when schemaname or
relname was passed as NULL, the error incorrectly reported the
argument name as "relation" in both cases:
ERROR: argument "relation" must not be null
This was misleading, especially for schemaname, and inconsistent with
the function's SQL-visible argument names.
The cause is that cleararginfo[] in attribute_stats.c used
"relation" for both the schema-name and relation-name arguments.
This commit fixes the issue by using "schemaname" and "relname" instead,
matching the function's declared argument names so that the error reports
the correct argument name.
Backpatch to v18, where pg_clear_attribute_stats() was introduced.
Author: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/4bf66c5e-8dd7-4ef3-8691-db67ecff6f16@tantorlabs.com
Backpatch-through: 18
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ae8c4bd558c5d55c5a357e910d496eea8ff33647
Modified Files
--------------
src/backend/statistics/attribute_stats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-07-15 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-15 12:25 pgsql: Fix argument names in pg_clear_attribute_stats() errors Fujii Masao <fujii@postgresql.org>
2026-07-15 12:26 pgsql: Fix argument names in pg_clear_attribute_stats() errors Fujii Masao <fujii@postgresql.org>
2026-07-15 12:26 pgsql: Fix argument names in pg_clear_attribute_stats() errors Fujii Masao <fujii@postgresql.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox