agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N 7+ messages / 1 participants [nested] [flat]
* pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N @ 2026-07-17 04:25 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Amit Kapila @ 2026-07-17 04:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = NONE). The previous text claimed that once the slot is disassociated with ALTER SUBSCRIPTION ... SET (slot_name = NONE), DROP SUBSCRIPTION "will no longer attempt any actions on a remote host". That is inaccurate: DROP SUBSCRIPTION may still connect to the publisher to drop internally-created table synchronization slots when some table synchronization is left unfinished. Reword to describe this, and note that if the publisher is unreachable those slots (and the main slot, if it still exists) must be dropped manually to avoid indefinitely reserving WAL. Reported-by: Jeff Davis <pgsql@j-davis.com> Author: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 14 Discussion: https://postgr.es/m/CAA4eK1+tyYSpPxMBy1974kjivuGeR7YY=yopwRGrK3+vCTysdg@mail.gmail.com Discussion: https://postgr.es/m/D908370F-2695-4231-851D-17179A6A6F2A@gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/03480907e9ff5d9bb3296b56c9b49db3df756e0f Modified Files -------------- doc/src/sgml/ref/drop_subscription.sgml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N @ 2026-07-17 04:25 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Amit Kapila @ 2026-07-17 04:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = NONE). The previous text claimed that once the slot is disassociated with ALTER SUBSCRIPTION ... SET (slot_name = NONE), DROP SUBSCRIPTION "will no longer attempt any actions on a remote host". That is inaccurate: DROP SUBSCRIPTION may still connect to the publisher to drop internally-created table synchronization slots when some table synchronization is left unfinished. Reword to describe this, and note that if the publisher is unreachable those slots (and the main slot, if it still exists) must be dropped manually to avoid indefinitely reserving WAL. Reported-by: Jeff Davis <pgsql@j-davis.com> Author: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 14 Discussion: https://postgr.es/m/CAA4eK1+tyYSpPxMBy1974kjivuGeR7YY=yopwRGrK3+vCTysdg@mail.gmail.com Discussion: https://postgr.es/m/D908370F-2695-4231-851D-17179A6A6F2A@gmail.com Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2572fc53128cdbd262bf91fb2e302e0c4459be6f Modified Files -------------- doc/src/sgml/ref/drop_subscription.sgml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N @ 2026-07-17 04:25 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Amit Kapila @ 2026-07-17 04:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = NONE). The previous text claimed that once the slot is disassociated with ALTER SUBSCRIPTION ... SET (slot_name = NONE), DROP SUBSCRIPTION "will no longer attempt any actions on a remote host". That is inaccurate: DROP SUBSCRIPTION may still connect to the publisher to drop internally-created table synchronization slots when some table synchronization is left unfinished. Reword to describe this, and note that if the publisher is unreachable those slots (and the main slot, if it still exists) must be dropped manually to avoid indefinitely reserving WAL. Reported-by: Jeff Davis <pgsql@j-davis.com> Author: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 14 Discussion: https://postgr.es/m/CAA4eK1+tyYSpPxMBy1974kjivuGeR7YY=yopwRGrK3+vCTysdg@mail.gmail.com Discussion: https://postgr.es/m/D908370F-2695-4231-851D-17179A6A6F2A@gmail.com Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/aa572d521a1116b2c8902b98f44baf402a3e5246 Modified Files -------------- doc/src/sgml/ref/drop_subscription.sgml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N @ 2026-07-17 04:25 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Amit Kapila @ 2026-07-17 04:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = NONE). The previous text claimed that once the slot is disassociated with ALTER SUBSCRIPTION ... SET (slot_name = NONE), DROP SUBSCRIPTION "will no longer attempt any actions on a remote host". That is inaccurate: DROP SUBSCRIPTION may still connect to the publisher to drop internally-created table synchronization slots when some table synchronization is left unfinished. Reword to describe this, and note that if the publisher is unreachable those slots (and the main slot, if it still exists) must be dropped manually to avoid indefinitely reserving WAL. Reported-by: Jeff Davis <pgsql@j-davis.com> Author: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 14 Discussion: https://postgr.es/m/CAA4eK1+tyYSpPxMBy1974kjivuGeR7YY=yopwRGrK3+vCTysdg@mail.gmail.com Discussion: https://postgr.es/m/D908370F-2695-4231-851D-17179A6A6F2A@gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ee1cffbb80a302f4d2336b601466a21d53ce55c0 Modified Files -------------- doc/src/sgml/ref/drop_subscription.sgml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N @ 2026-07-17 04:25 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Amit Kapila @ 2026-07-17 04:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = NONE). The previous text claimed that once the slot is disassociated with ALTER SUBSCRIPTION ... SET (slot_name = NONE), DROP SUBSCRIPTION "will no longer attempt any actions on a remote host". That is inaccurate: DROP SUBSCRIPTION may still connect to the publisher to drop internally-created table synchronization slots when some table synchronization is left unfinished. Reword to describe this, and note that if the publisher is unreachable those slots (and the main slot, if it still exists) must be dropped manually to avoid indefinitely reserving WAL. Reported-by: Jeff Davis <pgsql@j-davis.com> Author: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 14 Discussion: https://postgr.es/m/CAA4eK1+tyYSpPxMBy1974kjivuGeR7YY=yopwRGrK3+vCTysdg@mail.gmail.com Discussion: https://postgr.es/m/D908370F-2695-4231-851D-17179A6A6F2A@gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/44fc102c003f44e5238000c26a884e0e000c441e Modified Files -------------- doc/src/sgml/ref/drop_subscription.sgml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N @ 2026-07-17 04:25 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Amit Kapila @ 2026-07-17 04:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = NONE). The previous text claimed that once the slot is disassociated with ALTER SUBSCRIPTION ... SET (slot_name = NONE), DROP SUBSCRIPTION "will no longer attempt any actions on a remote host". That is inaccurate: DROP SUBSCRIPTION may still connect to the publisher to drop internally-created table synchronization slots when some table synchronization is left unfinished. Reword to describe this, and note that if the publisher is unreachable those slots (and the main slot, if it still exists) must be dropped manually to avoid indefinitely reserving WAL. Reported-by: Jeff Davis <pgsql@j-davis.com> Author: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 14 Discussion: https://postgr.es/m/CAA4eK1+tyYSpPxMBy1974kjivuGeR7YY=yopwRGrK3+vCTysdg@mail.gmail.com Discussion: https://postgr.es/m/D908370F-2695-4231-851D-17179A6A6F2A@gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ca22d7bab501016aae3604b15094b4e0950ea30d Modified Files -------------- doc/src/sgml/ref/drop_subscription.sgml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N @ 2026-07-17 04:25 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Amit Kapila @ 2026-07-17 04:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = NONE). The previous text claimed that once the slot is disassociated with ALTER SUBSCRIPTION ... SET (slot_name = NONE), DROP SUBSCRIPTION "will no longer attempt any actions on a remote host". That is inaccurate: DROP SUBSCRIPTION may still connect to the publisher to drop internally-created table synchronization slots when some table synchronization is left unfinished. Reword to describe this, and note that if the publisher is unreachable those slots (and the main slot, if it still exists) must be dropped manually to avoid indefinitely reserving WAL. Reported-by: Jeff Davis <pgsql@j-davis.com> Author: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 14 Discussion: https://postgr.es/m/CAA4eK1+tyYSpPxMBy1974kjivuGeR7YY=yopwRGrK3+vCTysdg@mail.gmail.com Discussion: https://postgr.es/m/D908370F-2695-4231-851D-17179A6A6F2A@gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d7b62e3c22102898a6106baa129a2e6b838b4bc1 Modified Files -------------- doc/src/sgml/ref/drop_subscription.sgml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2026-07-17 04:25 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-07-17 04:25 pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N Amit Kapila <akapila@postgresql.org> 2026-07-17 04:25 pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N Amit Kapila <akapila@postgresql.org> 2026-07-17 04:25 pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N Amit Kapila <akapila@postgresql.org> 2026-07-17 04:25 pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N Amit Kapila <akapila@postgresql.org> 2026-07-17 04:25 pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N Amit Kapila <akapila@postgresql.org> 2026-07-17 04:25 pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N Amit Kapila <akapila@postgresql.org> 2026-07-17 04:25 pgsql: Doc: Clarify DROP SUBSCRIPTION behavior after SET (slot_name = N Amit Kapila <akapila@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox