agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Revert "Add GROUP BY ALL". 2+ messages / 1 participants [nested] [flat]
* pgsql: Revert "Add GROUP BY ALL". @ 2026-07-17 20:14 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2026-07-17 20:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Add GROUP BY ALL". This reverts commit ef38a4d9756db9ae1d20f40aa39f3cf76059b81a which implemented the GROUP BY ALL syntax, as well as 2ce745836 which made some comment improvements therein. A postcommit review discovered that GROUP BY ALL missed our special handling of entries that also appear in an ORDER BY in the query. This caused the query to return wrong results when ORDER BY specifies non-default equality semantics. While this should be fixable with some refactoring, doing it cleanly seems like too much code churn for late beta. We'll revert and try again in v20. The reverted commit also included some additional comment wordsmithing and docs cleanup, which are retained as they weren't connected to the reverted feature. catversion bump needed due to change in struct Query. Reported-by: Chao Li <li.evan.chao@gmail.com> Author: Daniel Gustafsson <daniel@yesql.se> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/5243308F-8E5C-45AA-828C-FAD96C4F34DA@gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/a32733d8f10f0e35f7e4ee772ddbef552296577f Modified Files -------------- doc/src/sgml/queries.sgml | 25 ------- doc/src/sgml/ref/select.sgml | 13 +--- doc/src/sgml/ref/select_into.sgml | 2 +- src/backend/parser/analyze.c | 2 - src/backend/parser/gram.y | 14 ---- src/backend/parser/parse_clause.c | 63 +--------------- src/backend/utils/adt/ruleutils.c | 4 +- src/include/catalog/catversion.h | 2 +- src/include/nodes/parsenodes.h | 2 - src/include/parser/parse_clause.h | 1 - src/test/regress/expected/aggregates.out | 123 ------------------------------- src/test/regress/sql/aggregates.sql | 54 -------------- 12 files changed, 6 insertions(+), 299 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Revert "Add GROUP BY ALL". @ 2026-07-17 20:14 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2026-07-17 20:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Revert "Add GROUP BY ALL". This reverts commit ef38a4d9756db9ae1d20f40aa39f3cf76059b81a which implemented the GROUP BY ALL syntax, as well as 2ce745836 which made some comment improvements therein. A postcommit review discovered that GROUP BY ALL missed our special handling of entries that also appear in an ORDER BY in the query. This caused the query to return wrong results when ORDER BY specifies non-default equality semantics. While this should be fixable with some refactoring, doing it cleanly seems like too much code churn for late beta. We'll revert and try again in v20. The reverted commit also included some additional comment wordsmithing and docs cleanup, which are retained as they weren't connected to the reverted feature. catversion bump needed due to change in struct Query. Reported-by: Chao Li <li.evan.chao@gmail.com> Author: Daniel Gustafsson <daniel@yesql.se> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/5243308F-8E5C-45AA-828C-FAD96C4F34DA@gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/372b8d1adb76740123791e9ded4f665b175f5bf5 Modified Files -------------- doc/src/sgml/queries.sgml | 25 ------- doc/src/sgml/ref/select.sgml | 13 +--- doc/src/sgml/ref/select_into.sgml | 2 +- src/backend/parser/analyze.c | 2 - src/backend/parser/gram.y | 14 ---- src/backend/parser/parse_clause.c | 63 +--------------- src/backend/utils/adt/ruleutils.c | 4 +- src/include/catalog/catversion.h | 2 +- src/include/nodes/parsenodes.h | 2 - src/include/parser/parse_clause.h | 1 - src/test/regress/expected/aggregates.out | 123 ------------------------------- src/test/regress/sql/aggregates.sql | 54 -------------- 12 files changed, 6 insertions(+), 299 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-07-17 20:14 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-07-17 20:14 pgsql: Revert "Add GROUP BY ALL". Tom Lane <tgl@sss.pgh.pa.us> 2026-07-17 20:14 pgsql: Revert "Add GROUP BY ALL". Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox