agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix yet another portability problem in new NLS test. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix yet another portability problem in new NLS test. @ 2026-07-17 22:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2026-07-17 22:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix yet another portability problem in new NLS test. Álvaro reported offlist that his machine was passing the new-in-v19 nls.sql test in "make check" but not in "make installcheck". On investigation, the cause turned out to be that he has LANGUAGE set in his environment, and with (at least recent versions of) glibc that overrides LC_MESSAGES and friends, as per previous research by Bryan Green. "make check" works because pg_regress unsets LANGUAGE before starting the postmaster, but in installcheck mode we're exposed to the prevailing value and we lose. We're already hacking the value of LANGUAGE in this test for Solaris, so let's just extend that to unsetting LANGUAGE on every other platform. Reported-by: Álvaro Herrera <alvherre@kurilemu.de> Diagnosed-by: Andrew Dunstan <andrew@dunslane.net> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/a337896e-5bff-490b-afc9-c545f06c014c@gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f5dfd52553d3b041e30e9b1f1c6eb9f7af55fbdb Modified Files -------------- src/test/regress/regress.c | 6 ++++++ 1 file changed, 6 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix yet another portability problem in new NLS test. @ 2026-07-17 22:08 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2026-07-17 22:08 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix yet another portability problem in new NLS test. Álvaro reported offlist that his machine was passing the new-in-v19 nls.sql test in "make check" but not in "make installcheck". On investigation, the cause turned out to be that he has LANGUAGE set in his environment, and with (at least recent versions of) glibc that overrides LC_MESSAGES and friends, as per previous research by Bryan Green. "make check" works because pg_regress unsets LANGUAGE before starting the postmaster, but in installcheck mode we're exposed to the prevailing value and we lose. We're already hacking the value of LANGUAGE in this test for Solaris, so let's just extend that to unsetting LANGUAGE on every other platform. Reported-by: Álvaro Herrera <alvherre@kurilemu.de> Diagnosed-by: Andrew Dunstan <andrew@dunslane.net> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/a337896e-5bff-490b-afc9-c545f06c014c@gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5ed9cee74c6cf23729bd5cc4dee3b0ebbd4aa7aa Modified Files -------------- src/test/regress/regress.c | 6 ++++++ 1 file changed, 6 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-07-17 22:08 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-07-17 22:08 pgsql: Fix yet another portability problem in new NLS test. Tom Lane <tgl@sss.pgh.pa.us> 2026-07-17 22:08 pgsql: Fix yet another portability problem in new NLS test. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox