agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix REASSIGN OWNED for subscriptions in other databases. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix REASSIGN OWNED for subscriptions in other databases. @ 2026-07-18 16:27 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-07-18 16:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix REASSIGN OWNED for subscriptions in other databases. Subscription objects are conceptually database-local objects, but pg_subscription is a shared catalog so that the launcher process can scan it. Check readers of pg_subscription to ensure that, unless it's the launcher process, it filters by MyDatabaseId. Most readers were already doing so, but this commit fixes REASSIGN OWNED and adds guards to catch other problems in the future. Also, clarify documentation. Author: Dilip Kumar <dilipbalaut@gmail.com> Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Discussion: https://postgr.es/m/20260710192533.4f.noahmisch@microsoft.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/03bcb6a7778e3eaa148c98107d878e2bd9b8a27b Modified Files -------------- contrib/postgres_fdw/t/010_subscription.pl | 45 ++++++++++++++++++++++++++++++ doc/src/sgml/ref/reassign_owned.sgml | 5 +++- doc/src/sgml/user-manag.sgml | 4 ++- src/backend/catalog/pg_subscription.c | 12 ++++++++ src/backend/commands/subscriptioncmds.c | 14 +++++++++- 5 files changed, 77 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix REASSIGN OWNED for subscriptions in other databases. @ 2026-07-18 16:27 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-07-18 16:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix REASSIGN OWNED for subscriptions in other databases. Subscription objects are conceptually database-local objects, but pg_subscription is a shared catalog so that the launcher process can scan it. Check readers of pg_subscription to ensure that, unless it's the launcher process, it filters by MyDatabaseId. Most readers were already doing so, but this commit fixes REASSIGN OWNED and adds guards to catch other problems in the future. Also, clarify documentation. Author: Dilip Kumar <dilipbalaut@gmail.com> Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Discussion: https://postgr.es/m/20260710192533.4f.noahmisch@microsoft.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e727c6f2ef5c75a282fbef9cb8adc0c1c6c7978e Modified Files -------------- contrib/postgres_fdw/t/010_subscription.pl | 45 ++++++++++++++++++++++++++++++ doc/src/sgml/ref/reassign_owned.sgml | 5 +++- doc/src/sgml/user-manag.sgml | 4 ++- src/backend/catalog/pg_subscription.c | 12 ++++++++ src/backend/commands/subscriptioncmds.c | 14 +++++++++- 5 files changed, 77 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-07-18 16:27 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-07-18 16:27 pgsql: Fix REASSIGN OWNED for subscriptions in other databases. Jeff Davis <jdavis@postgresql.org> 2026-07-18 16:27 pgsql: Fix REASSIGN OWNED for subscriptions in other databases. Jeff Davis <jdavis@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox