agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedpgsql: pg_resetwal: do not allow zero next multixact offset
2+ messages / 1 participants
[nested] [flat]
* pgsql: pg_resetwal: do not allow zero next multixact offset
@ 2026-07-27 13:08 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Linnakangas @ 2026-07-27 13:08 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
pg_resetwal: do not allow zero next multixact offset
Offset 0 is the "invalid" marker in pg_multixact/offsets since offsets
went 64-bit and the allocator stopped skipping it. pg_resetwal could
still produce it via -O 0 or guessed control values, breaking the first
multixact created after the reset ("MultiXact n has invalid offset",
and vacuum of the affected table fails from then on). Reject -O 0 like
-m and -o already do, and guess 1 like initdb does.
Author: Zsolt Parragi <zsolt.parragi@percona.com>
Discussion: https://www.postgresql.org/message-id/CAN4CZFNoO6MUkg526TmA=mC_RjY2gp4VKCnvK6y12v3ppOkhJA@mail.gmail...
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2cad308cb8f1c88f97f617ef9281f08c2f722277
Modified Files
--------------
src/bin/pg_resetwal/pg_resetwal.c | 6 +++++-
src/bin/pg_resetwal/t/001_basic.pl | 4 ++++
2 files changed, 9 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: pg_resetwal: do not allow zero next multixact offset
@ 2026-07-27 13:08 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Linnakangas @ 2026-07-27 13:08 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
pg_resetwal: do not allow zero next multixact offset
Offset 0 is the "invalid" marker in pg_multixact/offsets since offsets
went 64-bit and the allocator stopped skipping it. pg_resetwal could
still produce it via -O 0 or guessed control values, breaking the first
multixact created after the reset ("MultiXact n has invalid offset",
and vacuum of the affected table fails from then on). Reject -O 0 like
-m and -o already do, and guess 1 like initdb does.
Author: Zsolt Parragi <zsolt.parragi@percona.com>
Discussion: https://www.postgresql.org/message-id/CAN4CZFNoO6MUkg526TmA=mC_RjY2gp4VKCnvK6y12v3ppOkhJA@mail.gmail...
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/31974f64f029a29a6d7eeeb3f870030beee2066f
Modified Files
--------------
src/bin/pg_resetwal/pg_resetwal.c | 6 +++++-
src/bin/pg_resetwal/t/001_basic.pl | 4 ++++
2 files changed, 9 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-07-27 13:08 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-27 13:08 pgsql: pg_resetwal: do not allow zero next multixact offset Heikki Linnakangas <heikki.linnakangas@iki.fi>
2026-07-27 13:08 pgsql: pg_resetwal: do not allow zero next multixact offset Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox