agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix incorrect Result node flattening logic 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix incorrect Result node flattening logic @ 2026-07-31 01:16 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: David Rowley @ 2026-07-31 01:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect Result node flattening logic This fixes some incorrect flattening of nested Result nodes during create_plan that was introduced by f2bae51df. That commit failed to maintain the logic that checks for subplans and gating quals from the nested Result node before flattening, and that could result in the nested gating qual and subplan being lost, which could produce incorrect results. Bug: #19579 Reported-by: Viktor Leis <leis@in.tum.de> Author: Ayush Tiwari <ayushtiwari.slg01@gmail.com> Reviewed-by: David Rowley <dgrowleyml@gmail.com> Discussion: https://postgr.es/m/19579-e6296b6c9fc0591c@postgresql.org Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d6eac691747499645f21398c9e305d7a671e0229 Modified Files -------------- src/backend/optimizer/plan/createplan.c | 21 +++++++++++---------- src/test/regress/expected/join.out | 11 +++++++++++ src/test/regress/sql/join.sql | 8 ++++++++ 3 files changed, 30 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix incorrect Result node flattening logic @ 2026-07-31 01:16 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: David Rowley @ 2026-07-31 01:16 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect Result node flattening logic This fixes some incorrect flattening of nested Result nodes during create_plan that was introduced by f2bae51df. That commit failed to maintain the logic that checks for subplans and gating quals from the nested Result node before flattening, and that could result in the nested gating qual and subplan being lost, which could produce incorrect results. Bug: #19579 Reported-by: Viktor Leis <leis@in.tum.de> Author: Ayush Tiwari <ayushtiwari.slg01@gmail.com> Reviewed-by: David Rowley <dgrowleyml@gmail.com> Discussion: https://postgr.es/m/19579-e6296b6c9fc0591c@postgresql.org Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4a791db9bdbd48280e752578b93909995f93fe49 Modified Files -------------- src/backend/optimizer/plan/createplan.c | 21 +++++++++++---------- src/test/regress/expected/join.out | 11 +++++++++++ src/test/regress/sql/join.sql | 8 ++++++++ 3 files changed, 30 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-07-31 01:16 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-07-31 01:16 pgsql: Fix incorrect Result node flattening logic David Rowley <drowley@postgresql.org> 2026-07-31 01:16 pgsql: Fix incorrect Result node flattening logic David Rowley <drowley@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox