agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Silence Coverity warning about unused visibilitymap_clear() resu 2+ messages / 1 participants [nested] [flat]
* pgsql: Silence Coverity warning about unused visibilitymap_clear() resu @ 2026-08-04 22:06 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 2+ messages in thread From: Melanie Plageman @ 2026-08-04 22:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Silence Coverity warning about unused visibilitymap_clear() result Commit c0d9864f5ce made all but one caller of visibilitymap_clear() check its return value, causing Coverity to flag the remaining unchecked call in heap_page_fix_vm_corruption(). This VM clear is not WAL-logged, so the caller doesn't need the return value of visibilitymap_clear(). Add an explicit void cast and comment to document that the return value is intentionally ignored. Backpatch to 19 when the number of callers discarding the return value dropped low enough to trigger Coverity's warning. Discussion: https://postgr.es/m/1065814.1784514869%40sss.pgh.pa.us Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/a37e5745453f76e4bec208920773ef9c90fd50d1 Modified Files -------------- src/backend/access/heap/pruneheap.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Silence Coverity warning about unused visibilitymap_clear() resu @ 2026-08-04 22:11 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 2+ messages in thread From: Melanie Plageman @ 2026-08-04 22:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Silence Coverity warning about unused visibilitymap_clear() result Commit c0d9864f5ce made all but one caller of visibilitymap_clear() check its return value, causing Coverity to flag the remaining unchecked call in heap_page_fix_vm_corruption(). This VM clear is not WAL-logged, so the caller doesn't need the return value of visibilitymap_clear(). Add an explicit void cast and comment to document that the return value is intentionally ignored. Backpatch to 19 when the number of callers discarding the return value dropped low enough to trigger Coverity's warning. Discussion: https://postgr.es/m/1065814.1784514869%40sss.pgh.pa.us Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2f768dda531c94c071972a68d77163fba35684a6 Modified Files -------------- src/backend/access/heap/pruneheap.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-04 22:11 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-04 22:06 pgsql: Silence Coverity warning about unused visibilitymap_clear() resu Melanie Plageman <melanieplageman@gmail.com> 2026-08-04 22:11 pgsql: Silence Coverity warning about unused visibilitymap_clear() resu Melanie Plageman <melanieplageman@gmail.com>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox