agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Build subscription conninfo after checking that it's enabled. 2+ messages / 1 participants [nested] [flat]
* pgsql: Build subscription conninfo after checking that it's enabled. @ 2026-08-05 19:58 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 19:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Build subscription conninfo after checking that it's enabled. If a subscription is disabled, don't try to build conninfo because that may generate a confusing error and try to disable an already-disabled subscription. Partially addresses finding 5 in report from linked discussion. Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8b73ceb78f8e40f82ef965b9a1e15a8344c61daf Modified Files -------------- src/backend/replication/logical/worker.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Build subscription conninfo after checking that it's enabled. @ 2026-08-05 19:58 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 19:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Build subscription conninfo after checking that it's enabled. If a subscription is disabled, don't try to build conninfo because that may generate a confusing error and try to disable an already-disabled subscription. Partially addresses finding 5 in report from linked discussion. Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f567e066d6e3d09b1db740d0a891b9464c64caa2 Modified Files -------------- src/backend/replication/logical/worker.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-05 19:58 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-05 19:58 pgsql: Build subscription conninfo after checking that it's enabled. Jeff Davis <jdavis@postgresql.org> 2026-08-05 19:58 pgsql: Build subscription conninfo after checking that it's enabled. Jeff Davis <jdavis@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox