agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Always check foreign-server USAGE when resolving subscription co 2+ messages / 1 participants [nested] [flat]
* pgsql: Always check foreign-server USAGE when resolving subscription co @ 2026-08-05 20:26 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Always check foreign-server USAGE when resolving subscription conninfo. Previously, this was skipped in some cases to avoid raising errors when conninfo wasn't even needed. That was wrong in cases where conninfo was needed. Now that we only build conninfo when needed, always perform the USAGE check. Addresses finding 7 in report from linked discussion. Co-authored-by: Shlok Kyal <shlok.kyal.oss@gmail.com> Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: Shlok Kyal <shlok.kyal.oss@gmail.com> Reviewed-by: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/dcfb02deed84dd400c32016be768b9ec760e4c42 Modified Files -------------- src/backend/catalog/pg_subscription.c | 23 ++++++++++------------- src/backend/commands/subscriptioncmds.c | 9 +-------- src/backend/replication/logical/worker.c | 4 ++-- src/include/catalog/pg_subscription.h | 2 +- src/test/regress/expected/subscription.out | 3 +++ src/test/regress/sql/subscription.sql | 3 +++ 6 files changed, 20 insertions(+), 24 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Always check foreign-server USAGE when resolving subscription co @ 2026-08-05 20:26 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Always check foreign-server USAGE when resolving subscription conninfo. Previously, this was skipped in some cases to avoid raising errors when conninfo wasn't even needed. That was wrong in cases where conninfo was needed. Now that we only build conninfo when needed, always perform the USAGE check. Addresses finding 7 in report from linked discussion. Co-authored-by: Shlok Kyal <shlok.kyal.oss@gmail.com> Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: Shlok Kyal <shlok.kyal.oss@gmail.com> Reviewed-by: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5ba18183c4ca34beeedf7023d1f260ba1f5e9f87 Modified Files -------------- src/backend/catalog/pg_subscription.c | 23 ++++++++++------------- src/backend/commands/subscriptioncmds.c | 9 +-------- src/backend/replication/logical/worker.c | 4 ++-- src/include/catalog/pg_subscription.h | 2 +- src/test/regress/expected/subscription.out | 3 +++ src/test/regress/sql/subscription.sql | 3 +++ 6 files changed, 20 insertions(+), 24 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-05 20:26 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-05 20:26 pgsql: Always check foreign-server USAGE when resolving subscription co Jeff Davis <jdavis@postgresql.org> 2026-08-05 20:26 pgsql: Always check foreign-server USAGE when resolving subscription co Jeff Davis <jdavis@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox