agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: For subscription DDL, demote user mapping checks to WARNING. 2+ messages / 1 participants [nested] [flat]
* pgsql: For subscription DDL, demote user mapping checks to WARNING. @ 2026-08-05 20:26 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org For subscription DDL, demote user mapping checks to WARNING. The checks are useful to report to the user, but there's no reason to raise an error. If needed while constructing conninfo, fdwconnection will raise an error then. Partially addresses finding 1, and addresses finding 13 in report from the linked discussion. Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Discussion: https://postgr.es/m/e103ae8daf74485e0c0ebde297fae735d38f54d1.camel@j-davis.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5c39be9e6d5cc4a49883162dd52b1427738b8186 Modified Files -------------- src/backend/commands/subscriptioncmds.c | 8 ++++---- src/backend/foreign/foreign.c | 14 +++++++++++++- src/include/foreign/foreign.h | 1 + src/test/regress/expected/subscription.out | 8 +++----- src/test/regress/sql/subscription.sql | 5 +---- 5 files changed, 22 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: For subscription DDL, demote user mapping checks to WARNING. @ 2026-08-05 20:26 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-08-05 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org For subscription DDL, demote user mapping checks to WARNING. The checks are useful to report to the user, but there's no reason to raise an error. If needed while constructing conninfo, fdwconnection will raise an error then. Partially addresses finding 1, and addresses finding 13 in report from the linked discussion. Reported-by: Noah Misch <noah@leadboat.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com Discussion: https://postgr.es/m/e103ae8daf74485e0c0ebde297fae735d38f54d1.camel@j-davis.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/caadb9e97f571e19f359a42ad186df877ea834c7 Modified Files -------------- src/backend/commands/subscriptioncmds.c | 8 ++++---- src/backend/foreign/foreign.c | 14 +++++++++++++- src/include/foreign/foreign.h | 1 + src/test/regress/expected/subscription.out | 8 +++----- src/test/regress/sql/subscription.sql | 5 +---- 5 files changed, 22 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-05 20:26 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-05 20:26 pgsql: For subscription DDL, demote user mapping checks to WARNING. Jeff Davis <jdavis@postgresql.org> 2026-08-05 20:26 pgsql: For subscription DDL, demote user mapping checks to WARNING. Jeff Davis <jdavis@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox