pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Add wait-for-lsn process-exit cleanup callback 2+ messages / 1 participants [nested] [flat]
* pgsql: Add wait-for-lsn process-exit cleanup callback @ 2026-08-18 12:02 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Alexander Korotkov @ 2026-08-18 12:02 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add wait-for-lsn process-exit cleanup callback WaitLSNCleanup() was called from ProcKill(), but not from AuxiliaryProcKill(), even though xlogwait.c sizes its shared memory to include NUM_AUXILIARY_PROCS and thus accepts calls from auxiliary processes. Such a process exiting while waiting would leave its entry in the heap. Register an on_shmem_exit callback lazily before a process enters a wait-for-lsn heap instead, as suggested by Noah: that keeps the cleanup local to xlogwait.c and makes it harder to miss a caller that needs it, rather than having to remember every process-kill path. Reported-by: Noah Misch <noah@leadboat.com> Author: Xuneng Zhou <xunengzhou@gmail.com> Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com> Discussion: https://postgr.es/m/20260706012642.f9.noahmisch%40microsoft.com Discussion: https://postgr.es/m/CABPTF7UtW_cAa%3DQh4RDfKiUqu3pJJE22ai9tbWJVERbeRyssLw%40mail.gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f994d2b71ebca8258f7c68be310077588aa62059 Modified Files -------------- src/backend/access/transam/xlogwait.c | 38 +++++++++++++++++++++++++++++++++++ src/backend/storage/lmgr/proc.c | 6 ------ 2 files changed, 38 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Add wait-for-lsn process-exit cleanup callback @ 2026-08-18 12:02 Alexander Korotkov <akorotkov@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Alexander Korotkov @ 2026-08-18 12:02 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add wait-for-lsn process-exit cleanup callback WaitLSNCleanup() was called from ProcKill(), but not from AuxiliaryProcKill(), even though xlogwait.c sizes its shared memory to include NUM_AUXILIARY_PROCS and thus accepts calls from auxiliary processes. Such a process exiting while waiting would leave its entry in the heap. Register an on_shmem_exit callback lazily before a process enters a wait-for-lsn heap instead, as suggested by Noah: that keeps the cleanup local to xlogwait.c and makes it harder to miss a caller that needs it, rather than having to remember every process-kill path. Reported-by: Noah Misch <noah@leadboat.com> Author: Xuneng Zhou <xunengzhou@gmail.com> Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com> Discussion: https://postgr.es/m/20260706012642.f9.noahmisch%40microsoft.com Discussion: https://postgr.es/m/CABPTF7UtW_cAa%3DQh4RDfKiUqu3pJJE22ai9tbWJVERbeRyssLw%40mail.gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7864a14c4370b11cac74bcdf4cae5bb6a6ae867b Modified Files -------------- src/backend/access/transam/xlogwait.c | 38 +++++++++++++++++++++++++++++++++++ src/backend/storage/lmgr/proc.c | 6 ------ 2 files changed, 38 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-18 12:02 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-18 12:02 pgsql: Add wait-for-lsn process-exit cleanup callback Alexander Korotkov <akorotkov@postgresql.org> 2026-08-18 12:02 pgsql: Add wait-for-lsn process-exit cleanup callback Alexander Korotkov <akorotkov@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox