pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Report single-page checksum failures in pg_stat_database 7+ messages / 1 participants [nested] [flat]
* pgsql: Report single-page checksum failures in pg_stat_database @ 2026-08-19 00:52 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2026-08-19 00:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Report single-page checksum failures in pg_stat_database Base backups reported checksum failures to pg_stat_database only for files with more than one failing page. Commit 6b9e875f728 placed the report inside the block emitting the per-file summary WARNING, which was skipped for a single failure. As a result, a backup failing on files with one corrupted page each left checksum_failures untouched. To fix, emit the per-file summary and the pgstat report for any non-zero failure count. The end-of-backup total WARNING had the same off-by-one and is now also emitted for a single failure. Author: Zsolt Parragi <zsolt.parragi@percona.com> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAN4CZFN+Bi6XmaH8zOdMWjoycYFx9nKtOr+dzQf0o-UQ+Rdqmw@mail.gmail.com Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/340f2ac626586d35b13c546609571474491d6332 Modified Files -------------- src/backend/backup/basebackup.c | 13 ++++++------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 ++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Report single-page checksum failures in pg_stat_database @ 2026-08-19 00:52 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2026-08-19 00:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Report single-page checksum failures in pg_stat_database Base backups reported checksum failures to pg_stat_database only for files with more than one failing page. Commit 6b9e875f728 placed the report inside the block emitting the per-file summary WARNING, which was skipped for a single failure. As a result, a backup failing on files with one corrupted page each left checksum_failures untouched. To fix, emit the per-file summary and the pgstat report for any non-zero failure count. The end-of-backup total WARNING had the same off-by-one and is now also emitted for a single failure. Author: Zsolt Parragi <zsolt.parragi@percona.com> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAN4CZFN+Bi6XmaH8zOdMWjoycYFx9nKtOr+dzQf0o-UQ+Rdqmw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/db0f6dd80a0323bd39a5566f72699b6cbfe204bc Modified Files -------------- src/backend/backup/basebackup.c | 13 ++++++------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 ++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Report single-page checksum failures in pg_stat_database @ 2026-08-19 00:52 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2026-08-19 00:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Report single-page checksum failures in pg_stat_database Base backups reported checksum failures to pg_stat_database only for files with more than one failing page. Commit 6b9e875f728 placed the report inside the block emitting the per-file summary WARNING, which was skipped for a single failure. As a result, a backup failing on files with one corrupted page each left checksum_failures untouched. To fix, emit the per-file summary and the pgstat report for any non-zero failure count. The end-of-backup total WARNING had the same off-by-one and is now also emitted for a single failure. Author: Zsolt Parragi <zsolt.parragi@percona.com> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAN4CZFN+Bi6XmaH8zOdMWjoycYFx9nKtOr+dzQf0o-UQ+Rdqmw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/39faf4de206ec05764c4e151507fdcefc6612929 Modified Files -------------- src/backend/backup/basebackup.c | 13 ++++++------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 ++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Report single-page checksum failures in pg_stat_database @ 2026-08-19 00:52 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2026-08-19 00:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Report single-page checksum failures in pg_stat_database Base backups reported checksum failures to pg_stat_database only for files with more than one failing page. Commit 6b9e875f728 placed the report inside the block emitting the per-file summary WARNING, which was skipped for a single failure. As a result, a backup failing on files with one corrupted page each left checksum_failures untouched. To fix, emit the per-file summary and the pgstat report for any non-zero failure count. The end-of-backup total WARNING had the same off-by-one and is now also emitted for a single failure. Author: Zsolt Parragi <zsolt.parragi@percona.com> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAN4CZFN+Bi6XmaH8zOdMWjoycYFx9nKtOr+dzQf0o-UQ+Rdqmw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7f92983dcd76afa03117da6ae2c0c60ed7ce74e9 Modified Files -------------- src/backend/backup/basebackup.c | 13 ++++++------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 ++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Report single-page checksum failures in pg_stat_database @ 2026-08-19 00:52 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2026-08-19 00:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Report single-page checksum failures in pg_stat_database Base backups reported checksum failures to pg_stat_database only for files with more than one failing page. Commit 6b9e875f728 placed the report inside the block emitting the per-file summary WARNING, which was skipped for a single failure. As a result, a backup failing on files with one corrupted page each left checksum_failures untouched. To fix, emit the per-file summary and the pgstat report for any non-zero failure count. The end-of-backup total WARNING had the same off-by-one and is now also emitted for a single failure. Author: Zsolt Parragi <zsolt.parragi@percona.com> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAN4CZFN+Bi6XmaH8zOdMWjoycYFx9nKtOr+dzQf0o-UQ+Rdqmw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/45c88d621ccc8fb7654c8b2e863de3e9d233380b Modified Files -------------- src/backend/backup/basebackup.c | 13 ++++++------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 ++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Report single-page checksum failures in pg_stat_database @ 2026-08-19 00:52 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2026-08-19 00:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Report single-page checksum failures in pg_stat_database Base backups reported checksum failures to pg_stat_database only for files with more than one failing page. Commit 6b9e875f728 placed the report inside the block emitting the per-file summary WARNING, which was skipped for a single failure. As a result, a backup failing on files with one corrupted page each left checksum_failures untouched. To fix, emit the per-file summary and the pgstat report for any non-zero failure count. The end-of-backup total WARNING had the same off-by-one and is now also emitted for a single failure. Author: Zsolt Parragi <zsolt.parragi@percona.com> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAN4CZFN+Bi6XmaH8zOdMWjoycYFx9nKtOr+dzQf0o-UQ+Rdqmw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f555ada9e149bb9430c1597ba60b21fb119be04d Modified Files -------------- src/backend/backup/basebackup.c | 13 ++++++------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 ++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Report single-page checksum failures in pg_stat_database @ 2026-08-19 00:52 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2026-08-19 00:52 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Report single-page checksum failures in pg_stat_database Base backups reported checksum failures to pg_stat_database only for files with more than one failing page. Commit 6b9e875f728 placed the report inside the block emitting the per-file summary WARNING, which was skipped for a single failure. As a result, a backup failing on files with one corrupted page each left checksum_failures untouched. To fix, emit the per-file summary and the pgstat report for any non-zero failure count. The end-of-backup total WARNING had the same off-by-one and is now also emitted for a single failure. Author: Zsolt Parragi <zsolt.parragi@percona.com> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com> Discussion: https://postgr.es/m/CAN4CZFN+Bi6XmaH8zOdMWjoycYFx9nKtOr+dzQf0o-UQ+Rdqmw@mail.gmail.com Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/19d900358fd6f200ada6aabfa4d44d83c16a3f0a Modified Files -------------- src/backend/replication/basebackup.c | 13 ++++++------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 16 +++++++++++++++- 2 files changed, 21 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2026-08-19 00:52 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-19 00:52 pgsql: Report single-page checksum failures in pg_stat_database Michael Paquier <michael@paquier.xyz> 2026-08-19 00:52 pgsql: Report single-page checksum failures in pg_stat_database Michael Paquier <michael@paquier.xyz> 2026-08-19 00:52 pgsql: Report single-page checksum failures in pg_stat_database Michael Paquier <michael@paquier.xyz> 2026-08-19 00:52 pgsql: Report single-page checksum failures in pg_stat_database Michael Paquier <michael@paquier.xyz> 2026-08-19 00:52 pgsql: Report single-page checksum failures in pg_stat_database Michael Paquier <michael@paquier.xyz> 2026-08-19 00:52 pgsql: Report single-page checksum failures in pg_stat_database Michael Paquier <michael@paquier.xyz> 2026-08-19 00:52 pgsql: Report single-page checksum failures in pg_stat_database Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox