pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Report specific SQLSTATEs for stats restore errors 2+ messages / 1 participants [nested] [flat]
* pgsql: Report specific SQLSTATEs for stats restore errors @ 2026-08-27 14:43 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Fujii Masao @ 2026-08-27 14:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Report specific SQLSTATEs for stats restore errors The pg_restore_*_stats() functions could report SQLSTATE XX000 for invalid variadic arguments, such as an unmatched name/value pair, a NULL argument name, or a non-text argument name. Attribute and extended statistics restores could also report XX000 when the supplied statistics exceed the number of slots PostgreSQL can store. These are not internal errors. They result from invalid caller input or a PostgreSQL implementation limit, but the lack of specific SQLSTATEs made clients treat them as internal errors. Assign appropriate SQLSTATEs to these errors so that applications and tests can classify them correctly. Backpatch to v19, but no further; changing ERRCODE assignments in released stable branches doesn't seem like a good idea. Bug: #19629 Reported-by: Zheng Wang <hackerzheng666@gmail.com> Reported-by: Yanjie Zhao Reported-by: Yiyang Liu Author: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/19629-76babc04b683594d@postgresql.org Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/398a6bdd933e2fe8ce8589ac728f649d1b70b3e4 Modified Files -------------- src/backend/statistics/stat_utils.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Report specific SQLSTATEs for stats restore errors @ 2026-08-27 14:43 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Fujii Masao @ 2026-08-27 14:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Report specific SQLSTATEs for stats restore errors The pg_restore_*_stats() functions could report SQLSTATE XX000 for invalid variadic arguments, such as an unmatched name/value pair, a NULL argument name, or a non-text argument name. Attribute and extended statistics restores could also report XX000 when the supplied statistics exceed the number of slots PostgreSQL can store. These are not internal errors. They result from invalid caller input or a PostgreSQL implementation limit, but the lack of specific SQLSTATEs made clients treat them as internal errors. Assign appropriate SQLSTATEs to these errors so that applications and tests can classify them correctly. Backpatch to v19, but no further; changing ERRCODE assignments in released stable branches doesn't seem like a good idea. Bug: #19629 Reported-by: Zheng Wang <hackerzheng666@gmail.com> Reported-by: Yanjie Zhao Reported-by: Yiyang Liu Author: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/19629-76babc04b683594d@postgresql.org Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4c5291435d40a0cf02b131b680a71e42243fcd04 Modified Files -------------- src/backend/statistics/stat_utils.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-27 14:43 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-27 14:43 pgsql: Report specific SQLSTATEs for stats restore errors Fujii Masao <fujii@postgresql.org> 2026-08-27 14:43 pgsql: Report specific SQLSTATEs for stats restore errors Fujii Masao <fujii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox