pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix empty FOREIGN_JOIN sublist validation 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix empty FOREIGN_JOIN sublist validation @ 2026-08-27 18:46 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Robert Haas @ 2026-08-27 18:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix empty FOREIGN_JOIN sublist validation FOREIGN_JOIN target sublists must contain at least two relation identifiers. However, the parser checked only for sublists with exactly one identifier, so FOREIGN_JOIN(()) was accepted. Reject sublists with fewer than two relation identifiers, and add regression coverage. Author: Chao Li <lic@highgo.com> Discussion: http://postgr.es/m/BEDC04E0-6732-4310-95BA-6EC34BC1442C@gmail.com Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/400c810ddbd7890f751913977e4442d71a0ebfc4 Modified Files -------------- contrib/pg_plan_advice/expected/syntax.out | 3 +++ contrib/pg_plan_advice/pgpa_parser.y | 2 +- contrib/pg_plan_advice/sql/syntax.sql | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix empty FOREIGN_JOIN sublist validation @ 2026-08-27 18:46 Robert Haas <rhaas@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Robert Haas @ 2026-08-27 18:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix empty FOREIGN_JOIN sublist validation FOREIGN_JOIN target sublists must contain at least two relation identifiers. However, the parser checked only for sublists with exactly one identifier, so FOREIGN_JOIN(()) was accepted. Reject sublists with fewer than two relation identifiers, and add regression coverage. Author: Chao Li <lic@highgo.com> Discussion: http://postgr.es/m/BEDC04E0-6732-4310-95BA-6EC34BC1442C@gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8c9c2e5c09aeda713640ccb26bfca0fdccc310d5 Modified Files -------------- contrib/pg_plan_advice/expected/syntax.out | 3 +++ contrib/pg_plan_advice/pgpa_parser.y | 2 +- contrib/pg_plan_advice/sql/syntax.sql | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-08-27 18:46 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-08-27 18:46 pgsql: Fix empty FOREIGN_JOIN sublist validation Robert Haas <rhaas@postgresql.org> 2026-08-27 18:46 pgsql: Fix empty FOREIGN_JOIN sublist validation Robert Haas <rhaas@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox