pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Report next_multi_offset as bigint in pg_control_checkpoint().
2+ messages / 1 participants
[nested] [flat]

* pgsql: Report next_multi_offset as bigint in pg_control_checkpoint().
@ 2026-08-27 19:26  Masahiko Sawada <msawada@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Masahiko Sawada @ 2026-08-27 19:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Report next_multi_offset as bigint in pg_control_checkpoint().

Commit bd8d9c9bdfa widened MultiXactOffset to 64 bits, but
pg_control_checkpoint() still handle checkPointCopy.nextMultiOffset as
xid type and declared next_multi_offset column as xid. Since xid is 32
bits wide, an offset above 2^32 was reported truncated, while
pg_controldata printed the full value of the same field.

This commit reports the column as bigint instead. That matches
pg_get_multixact_stats(), which already reports num_members and
members_size, both derived from these same offsets, as int8.

Backpatch to v19, where MultiXactOffset was widened.

Bump catalog version.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CAD21AoCvzerscfU8o4ARQ793yAGHpQ72r2x5apeC_W2-k=SLCQ@mail.gmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/45817676632b46fc9d2b97c8d432348e0ee4f1f4

Modified Files
--------------
doc/src/sgml/func/func-info.sgml        | 2 +-
src/backend/utils/misc/pg_controldata.c | 2 +-
src/include/catalog/catversion.h        | 2 +-
src/include/catalog/pg_proc.dat         | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Report next_multi_offset as bigint in pg_control_checkpoint().
@ 2026-08-27 19:26  Masahiko Sawada <msawada@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Masahiko Sawada @ 2026-08-27 19:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Report next_multi_offset as bigint in pg_control_checkpoint().

Commit bd8d9c9bdfa widened MultiXactOffset to 64 bits, but
pg_control_checkpoint() still handle checkPointCopy.nextMultiOffset as
xid type and declared next_multi_offset column as xid. Since xid is 32
bits wide, an offset above 2^32 was reported truncated, while
pg_controldata printed the full value of the same field.

This commit reports the column as bigint instead. That matches
pg_get_multixact_stats(), which already reports num_members and
members_size, both derived from these same offsets, as int8.

Backpatch to v19, where MultiXactOffset was widened.

Bump catalog version.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CAD21AoCvzerscfU8o4ARQ793yAGHpQ72r2x5apeC_W2-k=SLCQ@mail.gmail.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3fcb7167198e1b2ecf8cc0d934c8ffe53755e0ae

Modified Files
--------------
doc/src/sgml/func/func-info.sgml        | 2 +-
src/backend/utils/misc/pg_controldata.c | 2 +-
src/include/catalog/catversion.h        | 2 +-
src/include/catalog/pg_proc.dat         | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2026-08-27 19:26 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-08-27 19:26 pgsql: Report next_multi_offset as bigint in pg_control_checkpoint(). Masahiko Sawada <msawada@postgresql.org>
2026-08-27 19:26 pgsql: Report next_multi_offset as bigint in pg_control_checkpoint(). Masahiko Sawada <msawada@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox