agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Restrict REPACK (CONCURRENTLY) on user catalog tables. 2+ messages / 1 participants [nested] [flat]
* pgsql: Restrict REPACK (CONCURRENTLY) on user catalog tables. @ 2026-09-08 20:06 Masahiko Sawada <msawada@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Masahiko Sawada @ 2026-09-08 20:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restrict REPACK (CONCURRENTLY) on user catalog tables. REPACK (CONCURRENTLY) is not an MVCC-safe operation; it doesn't preserve the visibility information, which logical decoding needs because it reads user catalog tables under a historic snapshot. Disallow REPACK (CONCURRENTLY) on user catalog tables. Removing this check requires making it MVCC-safe and logical rewrite mappings. Backpatch to v19, where REPACK (CONCURRENTLY) was introduced. Reported-by: Nathan Bossart <nathandbossart@gmail.com> Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> Reviewed-by: Antonin Houska <ah@cybertec.at> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Reviewed-by: Alvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/apBIFWzHYOaG0auN%40nathan Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/86f7c82cf1023e3599f40f939727791a7090cd44 Modified Files -------------- contrib/test_decoding/expected/repack.out | 6 ++++++ contrib/test_decoding/sql/repack.sql | 5 +++++ doc/src/sgml/ref/repack.sgml | 8 ++++++++ src/backend/commands/repack.c | 13 +++++++++++++ 4 files changed, 32 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Restrict REPACK (CONCURRENTLY) on user catalog tables. @ 2026-09-08 20:06 Masahiko Sawada <msawada@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Masahiko Sawada @ 2026-09-08 20:06 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Restrict REPACK (CONCURRENTLY) on user catalog tables. REPACK (CONCURRENTLY) is not an MVCC-safe operation; it doesn't preserve the visibility information, which logical decoding needs because it reads user catalog tables under a historic snapshot. Disallow REPACK (CONCURRENTLY) on user catalog tables. Removing this check requires making it MVCC-safe and logical rewrite mappings. Backpatch to v19, where REPACK (CONCURRENTLY) was introduced. Reported-by: Nathan Bossart <nathandbossart@gmail.com> Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> Reviewed-by: Antonin Houska <ah@cybertec.at> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Reviewed-by: Alvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/apBIFWzHYOaG0auN%40nathan Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/04bb1500253489de049a0f26ff1843197c9da0c0 Modified Files -------------- contrib/test_decoding/expected/repack.out | 6 ++++++ contrib/test_decoding/sql/repack.sql | 5 +++++ doc/src/sgml/ref/repack.sgml | 8 ++++++++ src/backend/commands/repack.c | 13 +++++++++++++ 4 files changed, 32 insertions(+) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-08 20:06 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-08 20:06 pgsql: Restrict REPACK (CONCURRENTLY) on user catalog tables. Masahiko Sawada <msawada@postgresql.org> 2026-09-08 20:06 pgsql: Restrict REPACK (CONCURRENTLY) on user catalog tables. Masahiko Sawada <msawada@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox