agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Make on-access pruning pin visibility map before locking heap pa 2+ messages / 1 participants [nested] [flat]
* pgsql: Make on-access pruning pin visibility map before locking heap pa @ 2026-09-12 00:39 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 2+ messages in thread From: Melanie Plageman @ 2026-09-12 00:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make on-access pruning pin visibility map before locking heap page b46e1e54d078 pinned the VM after acquiring a cleanup lock on the heap page when on-access pruning. This was not correct, as pinning the VM may require I/O. Pin the VM before acquiring the lock. This could mean occasional unneeded pinning when the buffer is under contention, but that should be rare. Reported-by: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://postgr.es/m/CAAKRu_aR6e2mNVo-DNHDUfBE5i0cbE4%3Du%3D_Qi9%2Bv573qiGtBig%40mail.gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/512d3e8919b649d36a6f246c657c8b8df7536e8a Modified Files -------------- src/backend/access/heap/pruneheap.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Make on-access pruning pin visibility map before locking heap pa @ 2026-09-12 00:42 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 2+ messages in thread From: Melanie Plageman @ 2026-09-12 00:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Make on-access pruning pin visibility map before locking heap page b46e1e54d078 pinned the VM after acquiring a cleanup lock on the heap page when on-access pruning. This was not correct, as pinning the VM may require I/O. Pin the VM before acquiring the lock. This could mean occasional unneeded pinning when the buffer is under contention, but that should be rare. Reported-by: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://postgr.es/m/CAAKRu_aR6e2mNVo-DNHDUfBE5i0cbE4%3Du%3D_Qi9%2Bv573qiGtBig%40mail.gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b3609cd2db8d7fd13cc261b8b00d642cd31947cf Modified Files -------------- src/backend/access/heap/pruneheap.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-12 00:42 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-12 00:39 pgsql: Make on-access pruning pin visibility map before locking heap pa Melanie Plageman <melanieplageman@gmail.com> 2026-09-12 00:42 pgsql: Make on-access pruning pin visibility map before locking heap pa Melanie Plageman <melanieplageman@gmail.com>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox