agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Avoid setting pd_prune_xid when inserting frozen tuples 2+ messages / 1 participants [nested] [flat]
* pgsql: Avoid setting pd_prune_xid when inserting frozen tuples @ 2026-09-14 14:44 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 2+ messages in thread From: Melanie Plageman @ 2026-09-14 14:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid setting pd_prune_xid when inserting frozen tuples 378a216187a set pd_prune_xid on inserts so that on-access pruning could later set the pages all-visible. heap_multi_insert() skipped this only when setting the page all-frozen, but it can insert frozen tuples even when not setting the page all-frozen. Inserting frozen tuples should not set pd_prune_xid as they introduce no work for on-access pruning. Fix by only setting pd_prune_xid when inserting non-frozen tuples. Reported-by: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://postgr.es/m/CAAKRu_a02pu7U2S0qPZ5L%2BoWb2m2Zp965sOKCCLnKUAKNo-hfg%40mail.gmail.com Backpatch-through: 19 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/47f0fa62c00d32d8b8be41d052775c07c90024db Modified Files -------------- src/backend/access/heap/heapam.c | 6 +++--- src/backend/access/heap/heapam_xlog.c | 21 ++++++++++++++++----- 2 files changed, 19 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Avoid setting pd_prune_xid when inserting frozen tuples @ 2026-09-14 14:47 Melanie Plageman <melanieplageman@gmail.com> 0 siblings, 0 replies; 2+ messages in thread From: Melanie Plageman @ 2026-09-14 14:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid setting pd_prune_xid when inserting frozen tuples 378a216187a set pd_prune_xid on inserts so that on-access pruning could later set the pages all-visible. heap_multi_insert() skipped this only when setting the page all-frozen, but it can insert frozen tuples even when not setting the page all-frozen. Inserting frozen tuples should not set pd_prune_xid as they introduce no work for on-access pruning. Fix by only setting pd_prune_xid when inserting non-frozen tuples. Reported-by: Melanie Plageman <melanieplageman@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://postgr.es/m/CAAKRu_a02pu7U2S0qPZ5L%2BoWb2m2Zp965sOKCCLnKUAKNo-hfg%40mail.gmail.com Backpatch-through: 19 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/41a8548ad41854d88578aebcfdf54bbdca42d49e Modified Files -------------- src/backend/access/heap/heapam.c | 6 +++--- src/backend/access/heap/heapam_xlog.c | 21 ++++++++++++++++----- 2 files changed, 19 insertions(+), 8 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-14 14:47 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-14 14:44 pgsql: Avoid setting pd_prune_xid when inserting frozen tuples Melanie Plageman <melanieplageman@gmail.com> 2026-09-14 14:47 pgsql: Avoid setting pd_prune_xid when inserting frozen tuples Melanie Plageman <melanieplageman@gmail.com>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox