agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedpgsql: Fail REPACK in presence of invalid indexes, take 2
3+ messages / 2 participants
[nested] [flat]
* pgsql: Fail REPACK in presence of invalid indexes, take 2
@ 2026-09-15 15:19 Álvaro Herrera <alvherre@kurilemu.de>
2026-09-15 15:23 ` Re: pgsql: Fail REPACK in presence of invalid indexes, take 2 Peter Geoghegan <pg@bowt.ie>
0 siblings, 1 reply; 3+ messages in thread
From: Álvaro Herrera @ 2026-09-15 15:19 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fail REPACK in presence of invalid indexes, take 2
Commit 0c5d6269614e was confused about which indexes are potentially
problematic to rebuild: we thought only !indisready indexes could fail
to rebuild, and thus would attempt to rebuild !indisvalid ones that are
"ready" (that is, being maintained by DML but not yet completed).
However, that's wrong, because it could be that the validation phase of
such an index failed or was interrupted partway through. So, have
REPACK throw an error with all !indisvalid indexes, not just those
!indisready.
(!indisready implies !indisvalid, so this is an expansion of what
happened with the previous commit.)
Reported-by: shihao zhong <zhong950419@gmail.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/CAGRkXqRA4YetT8Nu3+1-45+ffTwi2bd1d1eDFME39Y9OPRMytQ@mail.gmail.com
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0cabab44f12f4169e52a0ba61d810dd2801cd517
Modified Files
--------------
doc/src/sgml/ref/repack.sgml | 6 ++++++
src/backend/commands/repack.c | 15 ++++++++-------
2 files changed, 14 insertions(+), 7 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Fail REPACK in presence of invalid indexes, take 2
2026-09-15 15:19 pgsql: Fail REPACK in presence of invalid indexes, take 2 Álvaro Herrera <alvherre@kurilemu.de>
@ 2026-09-15 15:23 ` Peter Geoghegan <pg@bowt.ie>
0 siblings, 0 replies; 3+ messages in thread
From: Peter Geoghegan @ 2026-09-15 15:23 UTC (permalink / raw)
To: Álvaro Herrera <alvherre@kurilemu.de>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Sep 15, 2026 at 11:19 AM Álvaro Herrera <alvherre@kurilemu.de> wrote:
> Fail REPACK in presence of invalid indexes, take 2
I don't see a commit on master. Was that an oversight?
--
Peter Geoghegan
^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fail REPACK in presence of invalid indexes, take 2
@ 2026-09-15 16:28 Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 0 replies; 3+ messages in thread
From: Álvaro Herrera @ 2026-09-15 16:28 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fail REPACK in presence of invalid indexes, take 2
Commit 0c5d6269614e was confused about which indexes are potentially
problematic to rebuild: we thought only !indisready indexes could fail
to rebuild, and thus would attempt to rebuild !indisvalid ones that are
"ready" (that is, being maintained by DML but not yet completed).
However, that's wrong, because it could be that the validation phase of
such an index failed or was interrupted partway through. So, have
REPACK throw an error with all !indisvalid indexes, not just those
!indisready.
(!indisready implies !indisvalid, so this is an expansion of what
happened with the previous commit.)
Reported-by: shihao zhong <zhong950419@gmail.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/CAGRkXqRA4YetT8Nu3+1-45+ffTwi2bd1d1eDFME39Y9OPRMytQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/78142821dfd42a7ca1010811ce77ff7b96218741
Modified Files
--------------
doc/src/sgml/ref/repack.sgml | 6 ++++++
src/backend/commands/repack.c | 15 ++++++++-------
2 files changed, 14 insertions(+), 7 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-09-15 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-09-15 15:19 pgsql: Fail REPACK in presence of invalid indexes, take 2 Álvaro Herrera <alvherre@kurilemu.de>
2026-09-15 15:23 ` Peter Geoghegan <pg@bowt.ie>
2026-09-15 16:28 pgsql: Fail REPACK in presence of invalid indexes, take 2 Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox